370635 - [Proto] timezone dialog has been screwed up by tzid changes

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Michael Büttner (no reviews TFN)]

bug #368121 introduced the new timezone ids, but the code in the timezone dialog wasn't updated accordingly.

Comment 1

[Michael Büttner (no reviews TFN)]

Attachment: patch v1

lilmatt, could you please double check that i updated the list correctly?

Comment 2

[Stefan Sitter [:ssitter]]

What versions are affected? Does this has impact on Lightning 0.3.1?

Comment 3

[Michael Büttner (no reviews TFN)]

(In reply to comment #2)
> What versions are affected? Does this has impact on Lightning 0.3.1?
Every version since 2007-01-30 (since bug #368121 has been checked in) is affected.

Comment 4

[Matthew (lilmatt) Willis]

Comment on attachment 255344 [details] [diff] [review]
patch v1

r=lilmatt

This matches

Comment 5

[Matthew (lilmatt) Willis]

This blocks 0.3.1

Comment 6

[Stefan Sitter [:ssitter]]

(In reply to comment #3)
> Every version since 2007-01-30 (since bug #368121 has been checked in)
> is affected.

Are you sure on this? I searched my local cvs tree on SUNBIRD_0_3_BRANCH and LIGHTNING_0_3_BRANCH but the only place I find '20050126_1' is in calICSService.cpp and calWcapCalendar.js.

Comment 7

[Matthew (lilmatt) Willis]

Thanks Stefan.
This never landed on the SUNBIRD or LIGHTNING branches.

Clearing blocking flag.

Comment 9

[Michael Büttner (no reviews TFN)]

Checked in on trunk and MOZILLA_1_8_BRANCH

Comment 10

[Stefan Sitter [:ssitter]]

Verified using Thunderbird 2.0pre (20070227) + Lightning 0.5pre (2007022803) + WCAP Enabler 0.3.