Closed Bug 370685 Opened 13 years ago Closed 13 years ago

Error when switching between General and Timezone preference tab

Categories

(Calendar :: Sunbird Only, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Sunbird 0.5

People

(Reporter: ssitter, Assigned: ssitter)

References

Details

(Keywords: regression)

Attachments

(2 files)

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.2pre) Gecko/20070216 Calendar/0.4a1

Steps to Reproduce:

1. Start Sunbird with clean profile
2. Open preferences, switch to Timezone tab, select timezone, save and close
3. Open preferences, switch from Timezone tab to General tab

Actual Results:

There are no preferences values displayed in the General tab, just empty edit boxes. First error in console:

Error: redeclaration of const Cc
Source File: chrome://calendar/content/calUtils.js 
Line: 42

followed by several identical errors (probably once for each preference):

Error: this.preferences.rootBranchInternal has no properties
Source File: chrome://global/content/bindings/preferences.xml
Line: 68

Expected Results:

All preferences are stored and displayed correct. No error messages in console.
Regression from Bug 366560
Works in Sunbird/0.4a1 (2007-02-12-03)
Fails in Sunbird/0.4a1 (2007-02-12-21)
Blocks: 366560
Keywords: regression
Attached patch patchSplinter Review
calUtils isn't needed for the general pane, from everything I can tell.
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #255488 - Flags: second-review?(mvl)
Attachment #255488 - Flags: first-review?(lilmatt)
Comment on attachment 255488 [details] [diff] [review]
patch

r=lilmatt
Attachment #255488 - Flags: first-review?(lilmatt) → first-review+
Comment on attachment 255488 [details] [diff] [review]
patch

r2=mvl
Attachment #255488 - Flags: second-review?(mvl) → second-review+
Whiteboard: [needs checkin]
Comment on attachment 255488 [details] [diff] [review]
patch

gGeneralPane::init() uses function now() from calUtils.js
Comment on attachment 255488 [details] [diff] [review]
patch

minusing based on ssitter's discovery
Attachment #255488 - Flags: first-review+ → first-review-
We'll need to figure out another way around this issue.
Whiteboard: [needs checkin]
Attachment #257415 - Flags: second-review?(mvl)
Attachment #257415 - Flags: first-review?
Attachment #257415 - Flags: first-review? → first-review?(lilmatt)
Comment on attachment 257415 [details] [diff] [review]
rev0 - include calUtils.js only once

This is what I was thinking of doing, but hadn't gotten around to testing.  Nice.  r=lilmatt
Attachment #257415 - Flags: first-review?(lilmatt) → first-review+
Comment on attachment 257415 [details] [diff] [review]
rev0 - include calUtils.js only once

r2=mvl
Attachment #257415 - Flags: second-review?(mvl) → second-review+
Assignee: jminta → ssitter
Status: ASSIGNED → NEW
Target Milestone: --- → Sunbird 0.5
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4pre) Gecko/20070405 Calendar/0.5pre.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.