370685 - Error when switching between General and Timezone preference tab

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.2pre) Gecko/20070216 Calendar/0.4a1

Steps to Reproduce:

1. Start Sunbird with clean profile
2. Open preferences, switch to Timezone tab, select timezone, save and close
3. Open preferences, switch from Timezone tab to General tab

Actual Results:

There are no preferences values displayed in the General tab, just empty edit boxes. First error in console:

Error: redeclaration of const Cc
Source File: chrome://calendar/content/calUtils.js 
Line: 42

followed by several identical errors (probably once for each preference):

Error: this.preferences.rootBranchInternal has no properties
Source File: chrome://global/content/bindings/preferences.xml
Line: 68

Expected Results:

All preferences are stored and displayed correct. No error messages in console.

Comment 1

[Stefan Sitter [:ssitter]]

Regression from Bug 366560
Works in Sunbird/0.4a1 (2007-02-12-03)
Fails in Sunbird/0.4a1 (2007-02-12-21)

Comment 2

[Joey Minta]

Attachment: patch

calUtils isn't needed for the general pane, from everything I can tell.

Comment 3

[Matthew (lilmatt) Willis]

Comment on attachment 255488 [details] [diff] [review]
patch

r=lilmatt

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 255488 [details] [diff] [review]
patch

r2=mvl

Comment 5

[Stefan Sitter [:ssitter]]

Comment on attachment 255488 [details] [diff] [review]
patch

gGeneralPane::init() uses function now() from calUtils.js

Comment 6

[Matthew (lilmatt) Willis]

Comment on attachment 255488 [details] [diff] [review]
patch

minusing based on ssitter's discovery

Comment 7

[Matthew (lilmatt) Willis]

We'll need to figure out another way around this issue.

Comment 8

[Stefan Sitter [:ssitter]]

Attachment: rev0 - include calUtils.js only once

Comment 9

[Matthew (lilmatt) Willis]

Comment on attachment 257415 [details] [diff] [review]
rev0 - include calUtils.js only once

This is what I was thinking of doing, but hadn't gotten around to testing.  Nice.  r=lilmatt

Comment 10

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 257415 [details] [diff] [review]
rev0 - include calUtils.js only once

r2=mvl

Comment 11

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED

Comment 12

[Martin Schröder [:mschroeder]]

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4pre) Gecko/20070405 Calendar/0.5pre.