[FIX]"ASSERTION: used padding property missing (out of memory?)" with overflow: hidden and position: fixed

RESOLVED FIXED in mozilla1.9alpha3

Status

()

RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: jruderman, Assigned: bzbarsky)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
mozilla1.9alpha3
assertion, testcase
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

12 years ago
###!!! ASSERTION: used padding property missing (out of memory?): 'p', file /Users/jruderman/trunk/mozilla/layout/generic/nsFrame.cpp, line 764

This is the same assertion that showed up in bug 366952, which dbaron fixed.
(Reporter)

Comment 1

12 years ago
Created attachment 255542 [details]
testcase
(Assignee)

Comment 2

12 years ago
Created attachment 255633 [details] [diff] [review]
I think this is the way to go
Attachment #255633 - Flags: superreview?(dbaron)
Attachment #255633 - Flags: review?(dbaron)
(Assignee)

Updated

12 years ago
Assignee: nobody → bzbarsky
OS: Mac OS X → All
Hardware: PC → All
Summary: "ASSERTION: used padding property missing (out of memory?)" with overflow: hidden and position: fixed → [FIX]"ASSERTION: used padding property missing (out of memory?)" with overflow: hidden and position: fixed
Target Milestone: --- → mozilla1.9alpha3
Who's passing in an |aPadding| without overriding nsIFrame::GetUsedPadding?
(Assignee)

Comment 4

12 years ago
nsHTMLScrollFrame::ReflowScrolledFrame.

I'm not sure how easy it is to override it, since there are so many different things the scrolled frame could be.  I suppose we could just put that in the nsFrame GetUsedPadding or something....
::-moz-scrolled-content already has padding:inherit, so I'm not even sure why that code is needed.
(Assignee)

Comment 6

12 years ago
Because inheriting a percentage does the wrong thing -- it computes the percentage using the scrollframe as the containing block.  See the blame for that Init() call in nsHTMLScrollFrame::ReflowScrolledFrame.
Attachment #255633 - Flags: superreview?(dbaron)
Attachment #255633 - Flags: superreview+
Attachment #255633 - Flags: review?(dbaron)
Attachment #255633 - Flags: review+
(Assignee)

Comment 8

12 years ago
Hmm.  Though I guess this means that all table rows, etc, will end up with these props, even though they don't need them.  Maybe I should put this code in nsGfxScrollFrame instead?
That would work -- especially if you set the property before the reflow state is constructed, since there could be a GetUsedPadding call later in the nsHTMLReflowState constructor.
(Assignee)

Updated

12 years ago
Attachment #255720 - Flags: superreview?(dbaron)
Attachment #255720 - Flags: review?(dbaron)
Attachment #255720 - Flags: superreview?(dbaron)
Attachment #255720 - Flags: superreview+
Attachment #255720 - Flags: review?(dbaron)
Attachment #255720 - Flags: review+
(Assignee)

Comment 11

12 years ago
Fixed.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Reporter)

Comment 12

11 years ago
Crashtest checked in.
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.