370931 - Navigation div not displayed on this nightly. Firefox and Safari do it fine.

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Ricky]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en; rv:1.8.1.2pre) Gecko/20070218 Camino/1.1a2+
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en; rv:1.8.1.2pre) Gecko/20070218 Camino/1.1a2+

the navigation div is at the top left of the page, it consists of some jpegs. It just doesn't show up on the recent nightlies.

Reproducible: Always

Steps to Reproduce:
1. Go to http://www.doverplains.org/page.cfm?id=12
2. Done.
Actual Results:  
Page loaded without navigation.

Expected Results:  
Displayed the navigation.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This is ad-blocking catching the "bannerdiv9" div id that contains the navigation stuff. 

div[id*="bannerDiv"],

Note this doesn't catch it on the trunk, because ids are case-sensitive there.  This rule was added last month for thelocal.se (its their main way of displaying ads), and can probably be changed to 

div[id="bannerDiv"],

to be safer?

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

s/its/it's/ :p

Ricky, you can get the images to display here by temporarily disabling ad-blocking and reloading the page.

Comment 3

[Ricky]

Oh, thanks a bunch. Is this then really a Camino bug then, since it has to do with adblock?

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #3)
> Is this then really a Camino bug then, since it has to do with adblock?

In that it's not a bug with the site, yes.  We don't consider every false positive or false negative to be a bug to be fixed, though this one might be.

Simon, Stuart, do you have an opinion on this rule?

Comment 5

[Stuart Morgan]

bannerDiv seems overly generic; 'banner' doesn't necessarily say 'ad' to me.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: rips it out

I was reaching the same conclusion.  Ordinarily I'd wait until the end of the month's bug, but let's not ship this in 1.1b1 and especially not 1.0.4.

Comment 7

[Stuart Morgan]

Comment on attachment 255800 [details] [diff] [review]
rips it out

sr=smorgan

Comment 8

[froodian (Ian Leue)]

Checked in on trunk and MOZILLA_1_8_BRANCH. 1.8.0 checkin coming later tonight.

Comment 9

[froodian (Ian Leue)]

I had a little more time than I thought.  Checked in on MOZILLA_1_8_0_BRANCH