370959 - Frontend code cleanup

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Asaf Romano (gone)]

Attachment: patch

Some cleanup I had in my tree which I would like to land separately.

Comment 1

[(not reading, please use [e-mail] instead)]

Comment on attachment 255731 [details] [diff] [review]
patch

r=sspitzer

Comment 2

[Asaf Romano (gone)]

Attachment: fix typo

Comment 3

[(not reading, please use [e-mail] instead)]

what was the typo?

(idea:  cgi powered by interdiff where I can feed it two https:// bugzilla attachment urls)

Comment 4

[Asaf Romano (gone)]

selectedNode vs aNode in nodeIsLivemarkItem.

Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.766; previous revision: 1.765
done
Checking in browser/components/places/content/controller.js;
/cvsroot/mozilla/browser/components/places/content/controller.js,v  <--  controller.js
new revision: 1.126; previous revision: 1.125
done
Checking in browser/components/places/content/menu.xml;
/cvsroot/mozilla/browser/components/places/content/menu.xml,v  <--  menu.xml
new revision: 1.66; previous revision: 1.65
done
Checking in browser/components/places/content/places.js;
/cvsroot/mozilla/browser/components/places/content/places.js,v  <--  places.js
new revision: 1.75; previous revision: 1.74
done
Checking in browser/components/places/content/tree.xml;
/cvsroot/mozilla/browser/components/places/content/tree.xml,v  <--  tree.xml
new revision: 1.54; previous revision: 1.53
done
Checking in browser/components/places/content/utils.js;
/cvsroot/mozilla/browser/components/places/content/utils.js,v  <--  utils.js
new revision: 1.11; previous revision: 1.10
done

Comment 5

[(not reading, please use [e-mail] instead)]

my bugzilla life is now complete:

https://bugzilla.mozilla.org/attachment.cgi?oldid=255737&action=interdiff&newid=255731&headers=1

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv