370977 - [10.4] History items have no tooltips

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: History, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

In the bookmarks side of things, we have tooltips for the title and the url columns (both display the url atm, bug 315340), but history has absolutely no tooltips at all.  

In order to see the full url of a history item with a long url, I have to resize the column (and with some urls, that might still not be wide enough).

There are starting to be enough of these things that we almost need a bookmarks/history parity bug :p

Comment 1

[Chris Lawson (gone)]

Hm. History seems to have magically acquired tooltips since this was filed. Maybe a 10.5+ thing?

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

10.4-only, but see bug 458259 for an argument as to why we should fix this ourselves everywhere.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/camino/src/history/HistoryOutlineViewDelegate.mm&rev=1.28&mark=399#399

Wonder if that perf comment is still true?

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

FWIW, outlineView:tooltipStringForItem: in BookmarkViewController has the same comment, and we seem to have lived with it successfully for years.

When this gets implemented, we should have cl try with his ginormous history and make sure it doesn't hurt.

Comment 5

[Chris Lawson (gone)]

Attachment: fix v1.0

(In reply to comment #4)
> When this gets implemented, we should have cl try with his ginormous history
> and make sure it doesn't hurt.

I doubt a huge history file makes any difference, since this deals with what's visible on the screen at any given time. I haven't tested with my normal profile yet, but I don't anticipate any problems.

If we don't see any problems, we might want to consider removing this comment both places it occurs; I doubt it's still relevant on modern hardware.

cl

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 480834 [details] [diff] [review]
fix v1.0

This works as advertised and is a (simplified) copy of the corresponding BookmarkOutlineView method.  I couldn't perceive any noticeable slowdown in new items being added to history or scrolling through thousands of history items, either.

We may end up doing something different in the future (bug 458259), but we may as well do this now, since we have the code, so r=ardissone.

Comment 7

[Takanori MATSUURA]

This bug lies at rest in the graveyard.