371055 - shortcuts for switching to numbered tab broke

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The shortcuts for switching to a numbered tab (on Linux/GTK it's Alt-1 for the first tab, Alt-2 for the second, etc... to Alt-9 for the last; on Windows it might be Ctrl?) stopped working between the 2007-02-19-04-trunk and 2007-02-20-04-trunk nightly builds.

Steps to reproduce:
 1. set up tabbed browser with two tabs and click in one of them
 2. hit Ctrl-PgUp and Ctrl-PgDn
 3. hit Alt-1 and Alt-2

Expected results:
 2. switches tabs
 3. switches tabs

Actual results:
 2. switches tabs
 3. nothing

Bug 370742 was suggested as a possible cause.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

This was indeed caused by bug 370742, but only because the browser code was doing something it shouldn't have to that now isn't allowed. This code dates back to when hyatt added the feature - I suspect tabbox wasn't quite so robust back then.