371121 - crash on clicking an insert trigger on a repeat within which is a select1 or select

Status: RESOLVED WORKSFORME

(Core Graveyard :: XForms, defect)

Description

[Stephen Green]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: XForms extension 0.7.0.1 in Firefox 2.0.0.1

If an xforms repeat contains a select or select1 then there is a crash when an insert trigger is used to add a row to the repeating rows

Reproducible: Always

Steps to Reproduce:
1. create xform with a repeat, a select1 inside it and an insert trigger
2. run the xform
3. click the insert trigger (button)
(note: this at least happens when the select or select1 uses dynamic model/instance rather than static list of names/values)
Actual Results:  
Browser crashed

Expected Results:  
repeating row added with selection drop-down included

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Could you upload a testcase (using "Add an attachment").

Comment 2

[Stephen Green]

Attachment: XForm example which crashes when a Catalogue Line is inserted

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

I get a parsing error when loading the testcase.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Because apparently it is a .zip file, not .xhtml file ;)

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Could you please make a minimized testcase.
The testcase attached runs very slowly but doesn't crash on
trunk/Linux.

Comment 6

[Stephen Green]

Attachment: minimalistic example of previous attachment

The crash takes place when the example is openned in Firefox on Windows XP and the trigger to insert a line within the repeat which contains the select is clicked.

Comment 7

[aaronr]

I tried to recreate this on trunk.  Couldn't.  I did recreate this on 1.8 branch, so we've fixed this bug sometime since shipping 0.7.0.1.  Since the crash on 1.8 branch is in the control list, I'm assuming the patch that fixed it was the one Olli did for bug 368627.  So I'm returning this WORKSFORME.