371249 - inline-block elements ignore text-decoration

Status: VERIFIED FIXED

(Core :: Layout: Block and Inline, defect, P3)

Description

[j.j.]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070220 Minefield/3.0a3pre
Build Identifier: 

No text-decoration is drawn when display: inline-block is set.

Reproducible: Always

Steps to Reproduce:
See testcase

Comment 1

[j.j.]

Attachment: testcase

Comment 2

[Adam Guthrie]

Looks like Ria may have already found the regression range, but I'll go ahead and say that I confirmed this regressed between 2007-01-27-04 and 2007-01-28 on Windows. http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-01-27+03&maxdate=2007-01-28+05&cvsroot=%2Fcvsroot

Comment 3

[j.j.]

(In reply to comment #2)
> Looks like Ria may have already found the regression range, but I'll go ahead
> and say that I confirmed this regressed between 2007-01-27-04 and 2007-01-28 on
> Windows.

In fact, this isn't a regression, we had no inline-block before.
Support for "inline-block" display property was checked in 2007-01-27 10:36 by dbaron (bug 9458).

Comment 4

[j.j.]

(In reply to comment #3)
> In fact, this isn't a regression, we had no inline-block before.

Otherwise, regression keyword is ok. This bug breaks
http://elektronotdienst.netfirms.com/
Links not underlined on current trunk, working with FF2.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Same bug was present for inline-block and table-caption.  I need to make sure there are bugs on file for the reftest failures for the tests that I wrote.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 286619 [details] [diff] [review]
patch

Want to request approval1.9, but it doesn't appear to be requestable.

Comment 7

[Damon Sicore (:damons)]

Comment on attachment 286619 [details] [diff] [review]
patch

a=release drivers

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Filed bug 403524 on the quirks mode testcase -- we should fix it by merging quirks and standards mode text-decoration.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Filed bug 403526 on the propagation to floats in standards mode.

Comment 11

[Marcia Knous [:marcia]]

verified fixed using  Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007113005 Minefield/3.0b2pre. I verified using the testcase and by visiting the site in comment 4.