Closed
Bug 371392
Opened 18 years ago
Closed 18 years ago
static nsRect instance in gfx triggering runtime static ctor/dtor warnings
Categories
(Core Graveyard :: GFX, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jaas, Assigned: jaas)
References
Details
(Whiteboard: [good first bug])
Attachments
(3 files)
|
1.47 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
|
43.56 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
|
1.90 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
Static nsRect instance in gfx triggering runtime static ctor/dtor warnings. Problem is probably here:
nsRect nsRenderingContextImpl::gBackbufferBounds = nsRect(0, 0, 0, 0);
|
||
Comment 1•18 years ago
|
||
In this particular case the static struct is probably ok, though it would be nicer if nsRect were POD and didn't have a constructor/destructor. We could just remove the NS_COUNT_CTOR/DTOR calls from nsRect, if we don't really care about leaking them.
|
||
Comment 3•18 years ago
|
||
should probably get some gfx people to review this as well.
Component: GFX: Thebes → GFX
|
|
||
Updated•18 years ago
|
Attachment #258586 -
Flags: review?(benjamin) → review+
Attachment #258586 -
Flags: superreview?(pavlov)
Attachment #258586 -
Flags: superreview?(pavlov) → superreview?(roc)
Actually, gBackbuffer and all the related code and nsIRenderingContext APIs are no longer used. We should just remove it all and leave the COUNT_CTOR/DTORs in.
Whiteboard: [good first bug]
Attachment #258586 -
Flags: superreview?(roc)
Comment on attachment 259698 [details] [diff] [review]
remove backbuffer v1.0
This has been tested on Mac OS X and Linux and it works on those two platforms. I haven't tried it on Windows.
Attachment #259698 -
Flags: review?(roc)
Comment on attachment 259698 [details] [diff] [review]
remove backbuffer v1.0
roc - please pay special attention to "view/src/nsViewManager.cpp" in your review, in particular the comments that surround removed code.
Comment on attachment 259698 [details] [diff] [review]
remove backbuffer v1.0
What's the story with those Mac plugin bugs that we were disabling double-buffering to fix? Are they not a problem with cairo?
Attachment #259698 -
Flags: superreview+
Attachment #259698 -
Flags: review?(roc)
Attachment #259698 -
Flags: review+
That Mac plugin stuff is from bug 62891, a long time ago. I don't think it is used by anyone any more.
|
Assignee | |
Comment 10•18 years ago
|
||
landed on trunk
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Comment 11•18 years ago
|
||
/gfx/src/nsRenderingContextImpl.h, line 320:
static nsIDrawingSurface* gBackbuffer; //singleton backbuffer
...could be removed as well, right?
|
|
Assignee | |
Comment 12•18 years ago
|
||
Andreas - thanks. Checked in.
Attachment #265127 -
Flags: superreview?(roc)
Attachment #265127 -
Flags: review?(roc)
Attachment #265127 -
Flags: superreview?(roc)
Attachment #265127 -
Flags: superreview+
Attachment #265127 -
Flags: review?(roc)
Attachment #265127 -
Flags: review+
Above patch checked in to trunk.
|
||
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•