[patch] Upgrade keychain entries at first use, not first change
RESOLVED
FIXED
in Camino1.6
Status
People
(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)
Tracking
({fixed1.8.1.5})
Details
Attachments
(1 attachment, 1 obsolete attachment)
|
4.45 KB,
patch
|
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
Sorry to add something else to the 1.1 list, but it's easy to do and I think it's important to do before we release. There's a lot of ugliness in the keychain code for legacy keychain item support that I'd really like to clean up. As we are now, though, we are essentially stuck with it forever since we only upgrade items when they change, and people could go years without changing passwords on commonly used accounts. The rationale for that behavior was that it would suck if someone tried a nightly, then went back to 1.0.x and were missing a bunch of saved passwords. That argument doesn't really apply to 1.1 though, since we don't have an expectation that people would go back to 1.0 from 1.1. So I think we should switch to upgrading all items as they are used the first time (where used means submitted, so we avoid the issue of accidently assigning http auth passwords to forms, or the other way around), which will allow us to drop the legacy support at some point in the foreseeable future.
|
(Assignee) | |
Comment 1•12 years ago
|
||
Created attachment 256795 [details] [diff] [review] fix
Attachment #256795 -
Flags: review?(joshmoz)
Attachment #256795 -
Flags: review?(joshmoz) → review+
|
|
(Assignee) | |
Updated•12 years ago
|
Attachment #256795 -
Flags: superreview?(mikepinkerton)
Summary: Upgrade keychain entries at first use, not first change → [patch] Upgrade keychain entries at first use, not first change
|
|
(Assignee) | |
Updated•12 years ago
|
Attachment #256795 -
Flags: superreview?(mikepinkerton)
|
|
(Assignee) | |
Comment 3•12 years ago
|
||
Created attachment 267806 [details] [diff] [review] updated Now with less bitrot.
Attachment #256795 -
Attachment is obsolete: true
Attachment #267806 -
Flags: superreview?(mikepinkerton)
|
||
Comment 4•12 years ago
|
||
Comment on attachment 267806 [details] [diff] [review] updated sr=pink
Attachment #267806 -
Flags: superreview?(mikepinkerton) → superreview+
|
|
(Assignee) | |
Comment 5•12 years ago
|
||
Landed on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8.1.5
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•