371480 - [patch] Upgrade keychain entries at first use, not first change

Status: RESOLVED FIXED

(Camino Graveyard :: OS Integration, defect)

Description

[Stuart Morgan]

Sorry to add something else to the 1.1 list, but it's easy to do and I think it's important to do before we release.

There's a lot of ugliness in the keychain code for legacy keychain item support that I'd really like to clean up. As we are now, though, we are essentially stuck with it forever since we only upgrade items when they change, and people could go years without changing passwords on commonly used accounts.

The rationale for that behavior was that it would suck if someone tried a nightly, then went back to 1.0.x and were missing a bunch of saved passwords. That argument doesn't really apply to 1.1 though, since we don't have an expectation that people would go back to 1.0 from 1.1. So I think we should switch to upgrading all items as they are used the first time (where used means submitted, so we avoid the issue of accidently assigning http auth passwords to forms, or the other way around), which will allow us to drop the legacy support at some point in the foreseeable future.

Comment 1

[Stuart Morgan]

Attachment: fix

Comment 2

[Stuart Morgan]

Pushing out :(

Comment 3

[Stuart Morgan]

Attachment: updated

Now with less bitrot.

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 267806 [details] [diff] [review]
updated

sr=pink

Comment 5

[Stuart Morgan]

Landed on trunk and MOZILLA_1_8_BRANCH.