371487 - Selected item in <select> should be gray when the <select> doesn't have focus

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jesse Ruderman]

Bug 371485 changed the selected item color to a darker blue, making Firefox match Safari for focused <selects>.  I think this color stands out too much, and that we should follow Safari by making non-focused <selects> use gray for selected items.

For example, on https://bugzilla.mozilla.org/query.cgi?format=advanced, "DUPLICATE" is dark blue when you first load the page in Firefox trunk, but light gray when you first load the page in Safari.

Comment 1

[Jesse Ruderman]

Oops, that's bug 371053, not bug 371485.

Comment 2

[Stefan [:stefanh]]

We have -moz-mac-secondaryhighlight for selected but non-focused treerows et al, that could probably be used.

Comment 3

[Stefan [:stefanh]]

Attachment: demo patch

This is how it could be done. Note that this isn't really ready for review -- you'll need an ifdef so win/nix doesn't get the style rules (ugly). I can also imagine that Josh have some plans for this.

Comment 4

[Stefan [:stefanh]]

I think windows uses -moz-cellhighlight for selected and non-focused treecells. That could probably be used, but then win/nix people have to be convinced that they want it for html selects (from what I heard IE7 doesn't have it).

Comment 5

[Stefan [:stefanh]]

Comment on attachment 256325 [details] [diff] [review]
demo patch

Hmm... this will of course not work if you have an optgroup...

Comment 6

[Boris Zbarsky [:bzbarsky]]

You could use the ' ' combinator instead of '>' to deal with optgroups, no?

Comment 8

[Teune van Steeg]

This is fixed by bug 412281

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Josh/Colin: will bug 54488 make this work correctly for cases where they are foucsed and the app or the window goes to the background, or do we need a new (Cocoa Widget?) bug on that?