371488 - tab close button hover effect can persist/become locked when closing a tab

Status: RESOLVED FIXED

(Camino Graveyard :: Tabbed Browsing, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I think this is the odd hover bug I mentioned the other day.  At least I hope we only have one of them!

STR:

1. Open 4 tabs
2. Make the leftmost tab active
3. Hover over the close button of tab #3
4. Cmd-W

Actual: Close button of second tab (originally tab #3) has hover effect, even though it is not hovered.  Close button of rightmost tab (originally tab #4) also has the hover effect if you haven't moved the mouse (because the pointer *is* actually hovering over that close button at the moment).  Also, the hover effect is "stuck" on second tab until you mouse over it or switch windows/apps.

Expected: hover effect only on close button currently under pointer

Comment 1

[Chris Lawson (gone)]

Yep, I can repro that on 1.1b1 too. (Works with >4 tabs, too.)

Tracking rects 4, Camino 0?

Comment 2

[Stuart Morgan]

That's odd, the code looks like it should handle that case. I'll walk through in a debugger when I have a chance and see if I can figure out where it's getting confused.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I've got one stuck hover right now that appeared after adding or changing tabs (all overflown tabs), not closing one, so there must be another version of this out there, too :(

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I just had this happen again in the non-tab-closing case, and I think maybe a tooltip (either on the tab, or from content—I was on a wiki, and a number of the topmost links have tooltips) was active or disappearing right around the time the hover became stuck.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I saw this again last night right about when the Keychain authorisation dialogue popped up, so I wonder if the others I saw were related to tooltips (and this is a sort of "child window grabs focus" issue)?

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Here's a different STR:

Move your mouse (rather quickly) up from content over the close button and on up into the menubar.  There's a timing-related bit to it, but with a bit of trial-and-error, I got all 8 close buttons hover-stuck.  It's like playing Space Invaders or something.

In the process of playing, it looked like one or two might have gotten stuck on moves that terminated in the toolbar or bookmark bar (before I moved back down in, accidentally unsetting them, since I was using an up-and-down repetition pattern), but I'm pretty tired so I might be seeing things.

Comment 7

[Stuart Morgan]

Attachment: fix

This will fix most, if not all, of the cases that get it stuck. It certainly fixes comment 0, and the similar case that happens with mouse-wheel tab scrolling.

We never want the hover image to stay set when tracking rects disabled, and that was happening sometimes because of the optimizations that removed tracking rects on close buttons in non-hovered tabs.

Comment 8

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 265397 [details] [diff] [review]
fix

sr=pink

Comment 9

[Stuart Morgan]

Landed on trunk and MOZILLA_1_8_BRANCH.
If there are still other ways this happens, lets put them in new bugs.