371528 - Stop creating views for pages

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[Eli Friedman]

Attachment: Patch

Patch per summary.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

-        containerRect.y -= height;
-        containerRect.height += height;
-        vm->MoveViewTo(containerView, containerRect.x, containerRect.y);
-        nsRect r(0, 0, containerRect.width, containerRect.height);
-        vm->ResizeView(containerView, r, PR_FALSE);
+        conFrame->SetPosition(conFrame->GetPosition() + nsPoint(0, -height));

I don't know exactly what this code is doing, but it used to change size of the view, and there's no size change here anymore. So what's going on?

Comment 2

[Eli Friedman]

The old view-based code did some strange stuff which I believe ended up repositioning and resizing the rendered area of the page content frame without actually changing the frame's position. I pretty sure the resizing was a form of clipping, since views can't render outside their boundaries (how much that's the case with the display list code, I'm not completely sure, but somehow it worked.)

The new code is extremely straightforward: we just reposition the page content frame according to which page we're rendering.  For this approach to work, though, the page frame has to clip the page content frame, which is why I added that code.  (This confusing code exists to support the wacky way we do selection printing.)

Comment 3

[Eli Friedman]

Checked in.