371572 - Release SpiderMonkey 1.6.1

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Bob Clary [:bc] (inactive)]

Release SpiderMonkey 1.6.1 based on 1.8.0.11.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: update JS_GetImplementationVersion

Comment 2

[Bob Clary [:bc] (inactive)]

dveditz, ping approval with an update to the date so I can put a stake through this zombie's heart?

Comment 3

[Bob Clary [:bc] (inactive)]

If I can get approval, I'll update the date in the patch and release a SpiderMonkey 1.6.1 shortly.

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Bob, can you give a quick rationale?  We aren't opposed to taking this but would like to know the risk/benefits before granting approval...  What is the status on other branches?

Comment 5

[Bob Clary [:bc] (inactive)]

There is zero risk. It is a simple change in what is essentially only a human readable string. The benefit would be that I can do a final SpiderMonkey 1.6 release for anyone who is using SpiderMonkey 1.6.0 on the Gecko 1.8.0 branch who isn't ready or able to move to the versions on the Gecko 1.8.1 or 1.9.0 branches. They would get the benefit of any security related patches to SpiderMonkey which have landed since the original release on 21 Nov 2006.

If approved, I will update the patch to use a more recent date than JavaScript-C 1.6.1 2007-10-03.

As for the other branches, I need to do a release of SpiderMonkey 1.7 off of the Gecko 1.8.1 branch and a SpiderMonkey 1.8 off of the Gecko trunk as soon as I can. They will need this string updated as well, but that is essentially unrelated to this patch.

Comment 6

[Brendan Eich [:brendan]]

Caillon, this is an automatic rubber stamp. I'll lend you mine if yours is lost ;-).

/be

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 283176 [details] [diff] [review]
update JS_GetImplementationVersion 

Okay.  I wasn't sure if there was more involved other than simply changing the string.  Makes sense.  a=caillon for 1.8.0.15

Comment 8

[Alexander Sack]

please land on 1.8.0 branch

Comment 9

[Bob Clary [:bc] (inactive)]

/cvsroot/mozilla/js/src/jsapi.c,v  <--  jsapi.c
new revision: 3.214.2.11.2.15; previous revision: 3.214.2.11.2.14

with a new 2008-03-01 date.