37183 - [i18n]Hardcoded strings in nsMsgStatusFeedback.cpp

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[rchen]

I believe "Loading document..." is hardcoded in nsMsgStatusFeedback.cpp:

   setAttribute( rootWebshell, "Messenger:Status", "value", "Loading 
Document..." );

and "Document: Done" is hardcoded at

   setAttribute( rootWebshell, "Messenger:Status", "value", "Document: Done" );

Please move them to properties file.

Comment 1

[leger]

Putting on [nsbeta2+] radar.  

Comment 2

[selmer (gone)]

Thanks for volunteering for these Alec!

Comment 3

[Katsuhiko Momoi]

Localizability requirement -> QA contact to myself.

Comment 4

[Alec Flett]

fix in hand, waiting for tree to open

Comment 5

[Alec Flett]

fix is in!

Comment 6

[Allan Masri]

verified with June 2 build

Comment 7

[Katsuhiko Momoi]

While the strings have been extracted, I don't think we have the
full solution here yet for the following reasons:

1. The dynamic msg status shows up only in a separate mail viewing
   window. In the main Messenger View window, we are still using
   the static text from messenger.dtd file.
2. In a Message Compose window, the status msg is dynamic, but the wording
   is not consistent with other windows. It says "Done loading document"
   while other mail windows (also in 4.x) all say "Document: Done".  While 
   this may be loaded from editor.properties, there needs to be
   consistency in wording.

and a question,

3. Are the "..statusText.label" in messenger.dtd and messengercompose.dtd
   still needed?

Re-opening for 1 and 2.

Comment 8

[Alec Flett]

those are different bugs! The bug was making the strings localizable, you're 
talking about aesthetic bugs that have nothing to do with i18n... and they are 
definately not beta stoppers. 

re-closing this bug, please file new bugs if the current behavior is a big deal.

Comment 9

[Katsuhiko Momoi]

OK. I looked into this a bit more and found that the status message
became static some time before the current fix went in. 
The original reason for this bug was that we noticed the status
messages in PR1's Messenger window was only partially localized 
in PR1-Japanese build while they were dynamically changing. 
At PR1, the status message was dynamic. Some of the builds from late 
April still had a dynamic status message while the one from 5/16 does 
not. 

Alec, you're right in that there is a separate bug here. But I could
not discount a possibility that another bug was introduced during 
this fix. 
I would hesitate to verify this fix fully. Presumably, the effects of the 
extraction would be there once the other bug is fixed but I can only 
guess that that might be the case for the Messenger window.
In any case I'll file a separate bug for the static message status, 

Comment 10

[Katsuhiko Momoi]

I'm going to verify this now based on the separate mail
viewing window where I can see the message change and reflect 
what alecf has done for us.  I'll file a new bug on the non-dynamic 
state of the message status.  If that bug is fixed and if these
status msgs don't appear, then I'll re-open the bug. Until then,
let's consider this bug fix verified.