372025 - Duplicates in the history menu are not collapsed

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Asaf Romano (gone)]

Duplicated items in the history menu are not collapsed.

The code for collapsing duplicates lives in the treeviewer implementation for some reason.

Comment 1

[Brett Wilson]

For some sortings, you don't want duplicates collapsed, and you want to collapse them in different ways depending on the sorting. For example, sort by date you want adjacent duplicates collapsed, but not if you visited them at different times. If you then sort by title, you want all instances of that page collapsed. This is why collapsing is done in the view.

If you do not ever want duplicates, you can query for urls instead of visits.

Comment 2

[Asaf Romano (gone)]

Attachment: as simple

Many thanks, Brett.

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 256710 [details] [diff] [review]
as simple

r=sspitzer, as you are switching from RESULTS_AS_VISIT (1) to RESULTS_AS_URI (0), per brettw's suggestion.

Comment 4

[Asaf Romano (gone)]

mozilla/browser/base/content/browser-menubar.inc 1.110

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv