Closed Bug 37210 Opened 25 years ago Closed 25 years ago

Mis-ordering of includes

Categories

(SeaMonkey :: Build Config, defect, P3)

Sun
Solaris
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: neldredge, Assigned: cls)

Details

Attachments

(1 file)

A compilation command in a build looks like: c++ -o nsPluginHostImpl.o -c -fno-rtti -fno-exceptions -pedantic -Wno-long-long -O -g -I/usr/local/lib/glib/include -I/usr/local/include -I/usr/local/X11R6.4//include -DMOZILLA_CLIENT -include ../../../config-defs.h -Wp,-MD,.deps/nsPluginHostImpl.pp -DOSTYPE=\"SunOS5\" -DOJI -D_IMPL_NS_PLUGIN -I../../../dist/include -I../../../include -I/usr/local/X11R6.4//include -fPIC nsPluginHostImpl.cpp Note the order of -I options. This Solaris machine happens to have a /usr/local/include/gui.h, which is then included instead of ../../../include/gui.h. Since /usr/local/include/gui.h is in fact a tkobjc file, the consequences are dispiriting. :) So basically, mozilla should be careful to include *its* headers before the system's. My .mozconfig is mk_add_options MOZ_MAKE_FLAGS=-j3 ac_add_options --enable-optimize Latest CVS.
See if this patch fixes your problem.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Yes, that fixed it.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
marking verified.
Status: RESOLVED → VERIFIED
Target Milestone: --- → M16
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: