37210 - Mis-ordering of includes

Status: VERIFIED FIXED

Description

[Nate Eldredge]

A compilation command in a build looks like:

c++ -o nsPluginHostImpl.o -c -fno-rtti -fno-exceptions -pedantic -Wno-long-long
-O -g -I/usr/local/lib/glib/include -I/usr/local/include
-I/usr/local/X11R6.4//include -DMOZILLA_CLIENT -include ../../../config-defs.h
-Wp,-MD,.deps/nsPluginHostImpl.pp -DOSTYPE=\"SunOS5\" -DOJI -D_IMPL_NS_PLUGIN 
-I../../../dist/include -I../../../include     -I/usr/local/X11R6.4//include  
-fPIC nsPluginHostImpl.cpp

Note the order of -I options.

This Solaris machine happens to have a /usr/local/include/gui.h, which is then
included instead of ../../../include/gui.h.  Since /usr/local/include/gui.h is
in fact a tkobjc file, the consequences are dispiriting. :)

So basically, mozilla should be careful to include *its* headers before the
system's.

My .mozconfig is

  mk_add_options MOZ_MAKE_FLAGS=-j3
  ac_add_options --enable-optimize

Latest CVS.

Comment 1

[cls]

Created attachment 8010 [details] [diff] [review]
Moves OS_CFLAGS to end of CFLAGS

Comment 2

[cls]

See if this patch fixes your problem.

Comment 3

[Nate Eldredge]

Yes, that fixed it.

Comment 4

[Jon Granrose]

marking verified.