Closed
Bug 372200
Opened 18 years ago
Closed 18 years ago
extraneous code in gSessionHistoryObserver
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
People
(Reporter: asqueella, Assigned: asqueella)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.46 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
bug 324354 added this code:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/base/content/browser.js&rev=1.767&mark=322-331#311
You don't actually need to loop through all windows, since there's an instance of the observer in each window. It's enough to take care of your own gURLBar.
Attachment #256865 -
Flags: review?(gavin.sharp)
|
||
Comment 1•18 years ago
|
||
ok, btw, instead of this:
+ gURLBar.editor.enableUndo(false);
+ gURLBar.editor.enableUndo(true);
does gURLBar.editor.transactionManager.clear() have the same effect?
If it works, then it's probably better to use that.
|
Assignee | |
Comment 3•18 years ago
|
||
Attachment #256865 -
Attachment is obsolete: true
Attachment #256871 -
Flags: review?(gavin.sharp)
Attachment #256865 -
Flags: review?(gavin.sharp)
|
||
Updated•18 years ago
|
Attachment #256871 -
Flags: review?(gavin.sharp) → review+
|
|
||
Comment 4•18 years ago
|
||
Good catch!
|
|
Assignee | |
Comment 5•18 years ago
|
||
mozilla/browser/base/content/browser.js 1.768
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•