372343 - MSYS builds broken since the checkin of bug 370676

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

When I try to build the current trunk using VC8SP1 and MSYS, I get the following error:
midl : command line warning MIDL1009 : unknown argument ignored "D:/mozbuild/msys/app_config"
midl : command line warning MIDL1009 : unknown argument ignored "D:/mozbuild/msys/c_ext"
midl : command line warning MIDL1009 : unknown argument ignored "i:/"
midl : command line warning MIDL1009 : unknown argument ignored "d:/mozbuild/mozilla/other-licenses/ia2"
midl : command line warning MIDL1009 : unknown argument ignored "d:/mozbuild/mozilla/other-licenses/ia2/Accessible2.idl"
Creating .deps
Processing D:\mozbuild\msys\ms_ext
ms_ext
c1 : fatal error C1083: Cannot open source file: 'D:\mozbuild\msys\ms_ext': No such file or directory
midl : command line error MIDL1003 : error returned by the C preprocessor (2)

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Does it help?

Comment 2

[Benjamin Smedberg]

can we call MIDL with -flags instead of /flags? Most of the MS tools accept the -dash version, which avoids the MSYS path confusion.

Comment 3

[alexander :surkov (:asurkov)]

IIRC we can't, should try again.

Comment 4

[alexander :surkov (:asurkov)]

Attachment: patch2

Comment 5

[Ryan VanderMeulen [:RyanVM]]

patch2 works great :)

I do have one question, though. Reading the MIDL MSDN docs, aren't /c_ext and /ms_ext long-obsolete flags?
http://msdn2.microsoft.com/en-us/aa367320.aspx
http://msdn2.microsoft.com/en-us/aa367335.aspx

Attaching a patch which removes the obsolete flags. Do with it whatever you please.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Attachment: patch2 minus the obsolete midl flags

Comment 7

[alexander :surkov (:asurkov)]

Comment on attachment 257023 [details] [diff] [review]
patch2 minus the obsolete midl flags

Works for me

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Benjamin, if you're happy with this patch, can you also go ahead and check it in? Thanks!

Comment 9

[Benjamin Smedberg]

Attachment: Make this all easier to understand, rev. 1

I committed "patch2". However, I spent some time cleaning up this makefile and making it less confused.

Comment 10

[alexander :surkov (:asurkov)]

Comment on attachment 257054 [details] [diff] [review]
Make this all easier to understand, rev. 1

excellent, thank you for the patch.

Comment 11

[Benjamin Smedberg]

Fixed on trunk.