Require python in configure

RESOLVED FIXED

Status

Firefox Build System
General
RESOLVED FIXED
12 years ago
5 months ago

People

(Reporter: Benjamin Smedberg, Assigned: Benjamin Smedberg)

Tracking

Trunk

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
We're going to require python for the new build scripts. So we should error if we can't find it in configure.
(Assignee)

Comment 1

12 years ago
Created attachment 257694 [details] [diff] [review]
Require python, rev. 1
Attachment #257694 - Flags: review?(ted.mielczarek)
Comment on attachment 257694 [details] [diff] [review]
Require python, rev. 1

>Index: config/autoconf.mk.in
>===================================================================
> AUTOCONF	= @AUTOCONF@
> PERL		= @PERL@
>+PYTHON          = @PYTHON@
> RANLIB		= @RANLIB@
> WHOAMI		= @WHOAMI@
> UNZIP		= @UNZIP@
> ZIP		= @ZIP@

nit: make those line up, looks like your added line isn't using tabs like the others.

Do we need to enforce a minimum version of Python?  I know there was some discussion on #build and in email about Python versions.
Attachment #257694 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 3

12 years ago
Fixed on trunk.

For the moment, I don't think we need to specify a minimum python version. Pike's stuff seems to work with python 2.3+, and I don't think we're going to encounter anything lower than that.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

5 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.