Closed
Bug 372400
Opened 17 years ago
Closed 17 years ago
Require python in configure
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
2.38 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
We're going to require python for the new build scripts. So we should error if we can't find it in configure.
Assignee | ||
Comment 1•17 years ago
|
||
Attachment #257694 -
Flags: review?(ted.mielczarek)
Comment 2•17 years ago
|
||
Comment on attachment 257694 [details] [diff] [review] Require python, rev. 1 >Index: config/autoconf.mk.in >=================================================================== > AUTOCONF = @AUTOCONF@ > PERL = @PERL@ >+PYTHON = @PYTHON@ > RANLIB = @RANLIB@ > WHOAMI = @WHOAMI@ > UNZIP = @UNZIP@ > ZIP = @ZIP@ nit: make those line up, looks like your added line isn't using tabs like the others. Do we need to enforce a minimum version of Python? I know there was some discussion on #build and in email about Python versions.
Attachment #257694 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 3•17 years ago
|
||
Fixed on trunk. For the moment, I don't think we need to specify a minimum python version. Pike's stuff seems to work with python 2.3+, and I don't think we're going to encounter anything lower than that.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•