Closed
Bug 372689
Opened 17 years ago
Closed 17 years ago
Simplify text updates
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
People
(Reporter: longsonr, Assigned: longsonr)
Details
Attachments
(1 file, 1 obsolete file)
|
11.15 KB,
patch
|
Details | Diff | Splinter Review |
A common thing to do is to find the text frame parent of a text child and then call NotifyGlyphMetricsChange on in to force a redraw of the text element and its children. An UpdateGraphic function which found the parent and updated it would simplify things.
Attachment #257365 -
Flags: superreview?(tor)
Attachment #257365 -
Flags: review?(tor)
|
Assignee | |
Updated•17 years ago
|
Assignee: general → longsonr
Comment on attachment 257365 [details] [diff] [review] patch > nsSVGGlyphFrame::UpdateGraphic(PRBool suppressInvalidation) ... >+ nsSVGTextContainerFrame *containerFrame; >+ containerFrame = NS_STATIC_CAST(nsSVGTextContainerFrame *, mParent); Nit - combine declaration and initialization of containerFrame.
Attachment #257365 -
Flags: superreview?(tor)
Attachment #257365 -
Flags: superreview+
Attachment #257365 -
Flags: review?(tor)
Attachment #257365 -
Flags: review+
|
|
Assignee | |
Comment 2•17 years ago
|
||
Attachment #257365 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•17 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•