Closed Bug 372729 Opened 14 years ago Closed 14 years ago

scrollbar layout happens after onload

Categories

(Core :: Layout, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: sayrer, Assigned: roc)

References

()

Details

Attachments

(1 file)

Bug 363253 made scrollbar layout happen in a callback, and the linux perf box, this resulted in txul times decreasing by a large percentage. On, IRC bz wondered whether making scrollbar munging happen after onload is desirable.
Blocks: 363253
So the point is that DoneRemovingReflowRoots() is what fires onload and this comes before reflow callbacks.

Perhaps we should reverse the ordering of those two?
Flags: blocking1.9?
Yeah, I think we should.
Attached patch fixSplinter Review
patch to do just that
Assignee: nobody → roc
Status: NEW → ASSIGNED
Attachment #257416 - Flags: superreview?(bzbarsky)
Attachment #257416 - Flags: review?(bzbarsky)
Comment on attachment 257416 [details] [diff] [review]
fix

Let's try it.
Attachment #257416 - Flags: superreview?(bzbarsky)
Attachment #257416 - Flags: superreview+
Attachment #257416 - Flags: review?(bzbarsky)
Attachment #257416 - Flags: review+
Blocks: 267833
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: blocking1.9? → in-testsuite-
Resolution: --- → FIXED
Hmm.  This had no effect on Txul... I wonder why bug 363253 made Txul go down, then...
This is not needed on branch.
Would this be needed once bug 267833 lands?
Flags: blocking1.8.1.8?
No.  Not unless bug 363253 lands on branch.
Thanks. We don't have any plans to backport bug 363253, but we do want bug 267833 on the old branch. Clearing blocking1.8.1.8 nomination.
Flags: blocking1.8.1.8?
You need to log in before you can comment on or make changes to this bug.