372729 - scrollbar layout happens after onload

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert Sayre]

Bug 363253 made scrollbar layout happen in a callback, and the linux perf box, this resulted in txul times decreasing by a large percentage. On, IRC bz wondered whether making scrollbar munging happen after onload is desirable.

Comment 1

[Boris Zbarsky [:bzbarsky]]

So the point is that DoneRemovingReflowRoots() is what fires onload and this comes before reflow callbacks.

Perhaps we should reverse the ordering of those two?

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yeah, I think we should.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

patch to do just that

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 257416 [details] [diff] [review]
fix

Let's try it.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Checked in.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Hmm.  This had no effect on Txul... I wonder why bug 363253 made Txul go down, then...

Comment 7

[Boris Zbarsky [:bzbarsky]]

This is not needed on branch.

Comment 8

[Daniel Veditz [:dveditz]]

Would this be needed once bug 267833 lands?

Comment 9

[Boris Zbarsky [:bzbarsky]]

No.  Not unless bug 363253 lands on branch.

Comment 10

[Daniel Veditz [:dveditz]]

Thanks. We don't have any plans to backport bug 363253, but we do want bug 267833 on the old branch. Clearing blocking1.8.1.8 nomination.