Closed Bug 372823 Opened 13 years ago Closed 13 years ago

calendar-views.js needs a little cleanup

Categories

(Calendar :: Calendar Views, defect)

Sunbird 0.3.1
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Sunbird 0.5

People

(Reporter: mattwillis, Assigned: mattwillis)

Details

Attachments

(1 file)

Attached patch minor cleanupSplinter Review
We have a number of nice helper functions in calendar-views.js, but we're not using them everywhere within that file.
Attachment #257506 - Flags: first-review?(ctalbert.moz)
Target Milestone: --- → Sunbird 0.5
Whiteboard: [patch in hand][needs review ctalbert]
Comment on attachment 257506 [details] [diff] [review]
minor cleanup

Looks good.  Did some preliminary testing in Sunbird and lightning and did not see any blatant issues with this.
Attachment #257506 - Flags: first-review?(ctalbert.moz) → first-review+
Attachment #257506 - Flags: second-review?(jminta)
Attachment #257506 - Flags: second-review?(jminta) → second-review+
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [patch in hand][needs review ctalbert]
You need to log in before you can comment on or make changes to this bug.