Closed Bug 372911 Opened 18 years ago Closed 17 years ago

[he] migration wizard string change

Categories

(Mozilla Localizations :: he / Hebrew, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Pike, Assigned: tomer)

References

Details

(Keywords: fixed1.8.1.4)

Attachments

(1 file, 2 obsolete files)

We want to change the description of the homepage in the migration wizard,
http://lxr.mozilla.org/l10n-mozilla1.8/source/he/other-licenses/branding/firefox/brand.properties

It should look like http://lxr.mozilla.org/mozilla/source/other-licenses/branding/firefox/locales/en-US/brand.properties

The corresponding patch is the en-US part in https://bugzilla.mozilla.org/attachment.cgi?id=257411&action=diff#mozilla/other-licenses/branding/firefox/locales/en-US/brand.properties_sec1

Current String in English for homePageSingleStartMain:
"Firefox Start, a fast search page with search results by XXX"

New String:
"Firefox Start, a fast home page with built-in search"

Please create the patch as 

cvs -z3 diff -u he/other-licenses/branding/firefox/brand.properties

from the l10n directory, we'll try to grab those patches together and land them with the en-US change.

See bug 372409 and bug 371309 for more information.
Assignee: tsahi_75 → tomer
Attached patch Hebrew brand.properties patch (obsolete) — Splinter Review
Comment on attachment 257698 [details] [diff] [review]
Hebrew brand.properties patch

Could you produce a patch from the l10n top directory? The Index line would look like

Index: he/other-licenses/branding/firefox/brand.properties

That should make the landing much easier.

If you could remove the content that is going to get removed on en-US, too, that'd be of additional help.

Thanks.
Attached patch Hebrew brand.properties patch (obsolete) — Splinter Review
I made a new copy of the file, based on the en-us file. Is it what you intended?
Attachment #257698 - Attachment is obsolete: true
Comment on attachment 257702 [details] [diff] [review]
Hebrew brand.properties patch

Yes, this one looks great, thanks.
while at it, please fix homePageMigrationDescription to be
אנא בחר את דף הבית בו ברצונך להשתמש:

(In reply to comment #5)
> while at it, please fix homePageMigrationDescription to be
> אנא בחר את דף הבית בו ברצונך להשתמש:
> 

You right, this is absolutely a better translation.
Attachment #257702 - Attachment is obsolete: true
These patches have been landed as part of attachement 257830 and are fixed on the 1.8 branch.

Please land those patches on the trunk yourself, and mark your individual bugs FIXED once that happened.

Thanks again.

FILTER_OUT_MASS_CHANGE_IF_YOU_CARE
Keywords: fixed1.8.1.4
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: