372911 - [he] migration wizard string change

Status: RESOLVED FIXED

(Mozilla Localizations :: he / Hebrew, defect)

Description

[Axel Hecht [:Pike]]

We want to change the description of the homepage in the migration wizard,
http://lxr.mozilla.org/l10n-mozilla1.8/source/he/other-licenses/branding/firefox/brand.properties

It should look like http://lxr.mozilla.org/mozilla/source/other-licenses/branding/firefox/locales/en-US/brand.properties

The corresponding patch is the en-US part in https://bugzilla.mozilla.org/attachment.cgi?id=257411&action=diff#mozilla/other-licenses/branding/firefox/locales/en-US/brand.properties_sec1

Current String in English for homePageSingleStartMain:
"Firefox Start, a fast search page with search results by XXX"

New String:
"Firefox Start, a fast home page with built-in search"

Please create the patch as 

cvs -z3 diff -u he/other-licenses/branding/firefox/brand.properties

from the l10n directory, we'll try to grab those patches together and land them with the en-US change.

See bug 372409 and bug 371309 for more information.

Comment 1

[Tomer Cohen :tomer]

Attachment: Hebrew brand.properties patch

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 257698 [details] [diff] [review]
Hebrew brand.properties patch

Could you produce a patch from the l10n top directory? The Index line would look like

Index: he/other-licenses/branding/firefox/brand.properties

That should make the landing much easier.

If you could remove the content that is going to get removed on en-US, too, that'd be of additional help.

Thanks.

Comment 3

[Tomer Cohen :tomer]

Attachment: Hebrew brand.properties patch

I made a new copy of the file, based on the en-us file. Is it what you intended?

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 257702 [details] [diff] [review]
Hebrew brand.properties patch

Yes, this one looks great, thanks.

Comment 5

[Tsahi Asher]

while at it, please fix homePageMigrationDescription to be
אנא בחר את דף הבית בו ברצונך להשתמש:

Comment 6

[Tomer Cohen :tomer]

Attachment: Hebrew brand.properties patch (including Tsahi note)

(In reply to comment #5)
> while at it, please fix homePageMigrationDescription to be
> אנא בחר את דף הבית בו ברצונך להשתמש:
> 

You right, this is absolutely a better translation.

Comment 7

[Axel Hecht [:Pike]]

These patches have been landed as part of attachement 257830 and are fixed on the 1.8 branch.

Please land those patches on the trunk yourself, and mark your individual bugs FIXED once that happened.

Thanks again.

FILTER_OUT_MASS_CHANGE_IF_YOU_CARE