373012 - Time-related columns in buglist should contain hidden easily-sortable data

Status: NEW

(Bugzilla :: Query/Bug List, enhancement)

Description

[Gervase Markham [:gerv]]

I want to enhance Jesse's BugSort Greasemonkey script, which does client-side sorting of buglists. But it's very hard to do any of the date columns; you need to know what day of the week it is today, and the current timezone offset between you and the Bugzilla server.

If the <td>s in these columns had the time value as a time_t as an attribute or something, I could sort on that instead.

<td abbr="9564710025600">Fri 11:32</td>

Or we could use class="" or title="", at a pinch. Or <span style="display: none">. If we don't care about validation, of course, we could do anything :-)

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Here's a patch to start discussion.

Gerv

Comment 2

[Max Kanat-Alexander]

Comment on attachment 328948 [details] [diff] [review]
Patch v.1

Actually, bmo already has this--you might want to look at what it has, since that's what can be used by sorttable.js.

Comment 3

[Gervase Markham [:gerv]]

Max: is there any reason we can't just take b.m.o's patch to use sorttable.js and commit it to the Bugzilla trunk?

Gerv

Comment 4

[Gervase Markham [:gerv]]

Attachment: Patch v.2

This is pretty much a port of the b.m.o. code. The template has changed a bit, so I had to adapt. The copy of sorttable.js is unchanged from there - so it correctly updates the BUGLIST cookie.

Gerv

Comment 5

[Frédéric Buclin]

Comment on attachment 414067 [details] [diff] [review]
Patch v.2

Please test your patch. You will see that there are already arrows used to indicate which columns are in use to sort the buglist.

Comment 6

[Frédéric Buclin]

Comment on attachment 414067 [details] [diff] [review]
Patch v.2

>+                  headrow[i].childNodes[k].href = "javascript: return false;";

Also, this line throws errors to the error console everytime you click on a column header (also on bmo). Should be void(0) or something like that.

Comment 7

[Max Kanat-Alexander]

Also, we're not taking sorttable.js in this bug--there's a separate bug for that.

Comment 8

[Gervase Markham [:gerv]]

I'd still like to see this done, but having it assigned to me is misleading, as I'm not working on it.

Gerv