Closed Bug 373209 Opened 13 years ago Closed 13 years ago

Remember last selected tab in Lightning preferences pane

Categories

(Calendar :: Preferences, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ssitter, Assigned: ssitter)

Details

Attachments

(2 files)

Followup for Bug 372014 Comment #6 / Bug 372014 Comment #8

We should remember and restore the last selected tab in Lightning preferences pane. 

From a quick look at Thunderbird and Sunbird it seems that this can be done only with javascript foo, see example in:

http://lxr.mozilla.org/mozilla/source/calendar/base/content/preferences/advanced.xul#101

http://lxr.mozilla.org/mozilla/source/calendar/base/content/preferences/advanced.js#43
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Attachment #258722 - Flags: first-review?(lilmatt)
This new file belongs to 
mozilla/calendar/lightning/content/messenger-overlay-preferences.js
(I did not managed to include it in patch)
Attachment #258724 - Flags: first-review?(lilmatt)
Why would we not want to init the Lightning pane first?  I am thinking it might prevent the wrong pane from being quickly flashed on first load, but I also may be worrying about something that doesn't exist.
(In reply to comment #3)

I did not tested the different behaviors. I just thought it makes sense to first init the panes and then switch to it. This way you might prevent switching to the pane and then seeing the panes content being initialized.
But I have no preference in this case and can change the init order.
Comment on attachment 258722 [details] [diff] [review]
rev0 - remember selected tab

After testing, I think the order is a non-issue.  r=lilmatt
Attachment #258722 - Flags: first-review?(lilmatt) → first-review+
Comment on attachment 258724 [details]
rev0 - messenger-overlay-preferences.js

r=lilmatt
Attachment #258724 - Flags: first-review?(lilmatt) → first-review+
Patches checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Verified with thunderbird version 2.0pre (20070324), lightning 2007032404 and
lightning-wcap 20070324
VERIFIED per comment#8
Status: RESOLVED → VERIFIED
Component: Lightning Only → Preferences
QA Contact: lightning → preferences
You need to log in before you can comment on or make changes to this bug.