373209 - Remember last selected tab in Lightning preferences pane

Status: VERIFIED FIXED

(Calendar :: Preferences, defect)

Description

[Stefan Sitter [:ssitter]]

Followup for Bug 372014 Comment #6 / Bug 372014 Comment #8

We should remember and restore the last selected tab in Lightning preferences pane. 

From a quick look at Thunderbird and Sunbird it seems that this can be done only with javascript foo, see example in:

http://lxr.mozilla.org/mozilla/source/calendar/base/content/preferences/advanced.xul#101

http://lxr.mozilla.org/mozilla/source/calendar/base/content/preferences/advanced.js#43

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: rev0 - remember selected tab

Comment 2

[Stefan Sitter [:ssitter]]

Attachment: rev0 - messenger-overlay-preferences.js

This new file belongs to 
mozilla/calendar/lightning/content/messenger-overlay-preferences.js
(I did not managed to include it in patch)

Comment 3

[Matthew (lilmatt) Willis]

Why would we not want to init the Lightning pane first?  I am thinking it might prevent the wrong pane from being quickly flashed on first load, but I also may be worrying about something that doesn't exist.

Comment 4

[Stefan Sitter [:ssitter]]

(In reply to comment #3)

I did not tested the different behaviors. I just thought it makes sense to first init the panes and then switch to it. This way you might prevent switching to the pane and then seeing the panes content being initialized.
But I have no preference in this case and can change the init order.

Comment 5

[Matthew (lilmatt) Willis]

Comment on attachment 258722 [details] [diff] [review]
rev0 - remember selected tab

After testing, I think the order is a non-issue.  r=lilmatt

Comment 6

[Matthew (lilmatt) Willis]

Comment on attachment 258724 [details]
rev0 - messenger-overlay-preferences.js

r=lilmatt

Comment 7

[Matthew (lilmatt) Willis]

Patches checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED

Comment 8

[Omar Bajraszewski]

Verified with thunderbird version 2.0pre (20070324), lightning 2007032404 and
lightning-wcap 20070324

Comment 9

[Martin Schröder [:mschroeder]]

VERIFIED per comment#8