Closed Bug 373221 Opened 17 years ago Closed 17 years ago

pref.daysoff.label in preferences->view has a grey background

Categories

(Calendar :: Preferences, defect)

x86
Windows XP
defect
Not set
trivial

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: bugzilla, Unassigned)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.2pre) Gecko/20070127 blub
Build Identifier: Lightning 2007030803

pref.daysoff.label in preferences->view has a dark grey background. The problem seems to be "caption label" instead of "label value" in views.xul. Patch is coming.

Reproducible: Always

Steps to Reproduce:
1. open preferences->views
2. look at "Include these days in the workweek"

Actual Results:  
has a dark grey background

Expected Results:  
should look like all the other labels
Attached patch Patch — — Splinter Review
So here it is my first patch to a mozilla application. Hope I did everything right.
Attachment #257850 - Flags: first-review?
Comment on attachment 257850 [details] [diff] [review]
Patch

Almost everything.  When requesting for review, you should put the bugzilla ID of the person you'd like to review it. Thanks for the patch. :-)
Attachment #257850 - Flags: first-review? → first-review?(lilmatt)
Comment on attachment 257850 [details] [diff] [review]
Patch

r=lilmatt

Thanks for the patch!
Attachment #257850 - Flags: first-review?(lilmatt) → first-review+
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: UNCONFIRMED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4pre) Gecko/20070405 Calendar/0.5pre.
Status: RESOLVED → VERIFIED
Component: General → Preferences
QA Contact: general → preferences
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: