373306 - selecting "annually" recurrence will misalign labels

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Cristian B.]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20070213 Sunbird/0.3.1

When selecting the "annually" option for a recurrence, the "Every:" and "Years" labels will 'jump' a few pixels, compared to all the other options.

Reproducible: Always

Steps to Reproduce:
1. Create or edit any event.
2. Mark the "Repeat" checkbox, and select "Set pattern..."
3. Change to/from "annually" option.
Actual Results:  
The "Every:" and "Years" labels will change their vertical position.

Expected Results:  
The two labels should have retained their vertical position.

Comment 1

[Martin Schröder [:mschroeder]]

Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.3pre) Gecko/20070308 Calendar/0.5pre.

Comment 2

[Stefan Sitter [:ssitter]]

Attachment: rev0 - center labels

Center controls and labels for Yearly recurrence by adding vbox and spacer. (Same solution as already used for Daily recurrence)

Comment 3

[Joey Minta]

Comment on attachment 258327 [details] [diff] [review]
rev0 - center labels

Although I can't imagine anyone objecting, this probably needs UI-review.

Comment 4

[Stefan Sitter [:ssitter]]

Attachment: rev0 - screenshot

Comment 5

[Joey Minta]

Comment on attachment 258327 [details] [diff] [review]
rev0 - center labels

+                <label value="&newevent.recurrence.every.label;"/>
+                <textbox id="yearly-years" value="1" size="3" oninput="validateIntegers(event); updateAccept();"/>

While you're here, wrapping this line would be nice.

Comment 6

[Stefan Sitter [:ssitter]]

Attachment: rev1 - center labels, word wrap

Patch as rev0 but with wrapped line.

Comment 7

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED

Comment 8

[Omar Bajraszewski]

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4pre) Gecko/20070324 Calendar/0.5pre

Comment 9

[Martin Schröder [:mschroeder]]

VERIFIED per comment#8