Closed Bug 373306 Opened 13 years ago Closed 13 years ago

selecting "annually" recurrence will misalign labels

Categories

(Calendar :: General, defect, trivial)

x86
Windows XP
defect
Not set
trivial

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: cryst1980, Assigned: ssitter)

Details

Attachments

(3 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20070213 Sunbird/0.3.1

When selecting the "annually" option for a recurrence, the "Every:" and "Years" labels will 'jump' a few pixels, compared to all the other options.

Reproducible: Always

Steps to Reproduce:
1. Create or edit any event.
2. Mark the "Repeat" checkbox, and select "Set pattern..."
3. Change to/from "annually" option.
Actual Results:  
The "Every:" and "Years" labels will change their vertical position.

Expected Results:  
The two labels should have retained their vertical position.
Version: unspecified → Sunbird 0.3.1
Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.3pre) Gecko/20070308 Calendar/0.5pre.
Status: UNCONFIRMED → NEW
Component: Internal Components → General
Ever confirmed: true
QA Contact: base → general
Version: Sunbird 0.3.1 → Trunk
Center controls and labels for Yearly recurrence by adding vbox and spacer. (Same solution as already used for Daily recurrence)
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Attachment #258327 - Flags: first-review?(jminta)
Comment on attachment 258327 [details] [diff] [review]
rev0 - center labels

Although I can't imagine anyone objecting, this probably needs UI-review.
Attached image rev0 - screenshot
Attachment #258327 - Flags: ui-review?(mvl)
Attachment #258327 - Flags: ui-review?(mvl) → ui-review+
Comment on attachment 258327 [details] [diff] [review]
rev0 - center labels

+                <label value="&newevent.recurrence.every.label;"/>
+                <textbox id="yearly-years" value="1" size="3" oninput="validateIntegers(event); updateAccept();"/>

While you're here, wrapping this line would be nice.
Attachment #258327 - Flags: first-review?(jminta) → first-review+
Patch as rev0 but with wrapped line.
Whiteboard: [needs checkin]
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [needs checkin]
Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4pre) Gecko/20070324 Calendar/0.5pre
VERIFIED per comment#8
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.