Closed
Bug 373395
Opened 19 years ago
Closed 19 years ago
Rename gGeneralPane object to avoid namespace issues with Thunderbird
Categories
(Calendar :: Lightning Only, defect)
Calendar
Lightning Only
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ssitter, Assigned: ssitter)
Details
Attachments
(1 file)
|
6.25 KB,
patch
|
mattwillis
:
first-review+
|
Details | Diff | Splinter Review |
After Bug 372014 being fixed Lightning uses the same overlay id and global javascript object as Thunderbird does for the General tab:
http://lxr.mozilla.org/mozilla1.8/search?string=gGeneralPane
http://lxr.mozilla.org/mozilla1.8/search?string=GeneralPaneOverlay
It does seem to work right now but I would prefer to rename gGeneralPane to avoid any future problems caused by namespace issues with Thunderbird.
Attachment #258046 -
Flags: first-review?(lilmatt)
|
||
Comment 1•19 years ago
|
||
Comment on attachment 258046 [details] [diff] [review]
rev0 - rename gGeneralPane
r=lilmatt
Attachment #258046 -
Flags: first-review?(lilmatt) → first-review+
|
|
||
Comment 2•19 years ago
|
||
Patch checked in on MOZILLA_1_8_BRANCH and trunk.
-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•