373483 - Crash [@ nsHTMLButtonElement::PostHandleEvent] when right-clicking on the button in this testcase

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, when right-clicking on the button, I crash with current trunk builds.
Talkback ID: TB30113065M
nsHTMLButtonElement::PostHandleEvent  [mozilla/content/html/content/src/nshtmlbuttonelement.cpp, line 435]
nsEventTargetChainItem::PostHandleEvent  [mozilla/content/events/src/nseventdispatcher.cpp, line 216]
nsEventTargetChainItem::HandleEventTargetChain  [mozilla/content/events/src/nseventdispatcher.cpp, line 317]
nsEventDispatcher::Dispatch  [mozilla/content/events/src/nseventdispatcher.cpp, line 472]
PresShell::HandleEventInternal  [mozilla/layout/base/nspresshell.cpp, line 5454]
PresShell::HandlePositionedEvent  [mozilla/layout/base/nspresshell.cpp, line 5345]
PresShell::HandleEvent  [mozilla/layout/base/nspresshell.cpp, line 5188]
nsViewManager::HandleEvent  [mozilla/view/src/nsviewmanager.cpp, line 1622]
nsViewManager::DispatchEvent  [mozilla/view/src/nsviewmanager.cpp, line 1575]
HandleEvent  [mozilla/view/src/nsview.cpp, line 174]
nsWindow::DispatchEvent  [mozilla/widget/src/windows/nswindow.cpp, line 1103]
nsWindow::DispatchMouseEvent  [mozilla/widget/src/windows/nswindow.cpp, line 6269]

This regressed between 2006-11-16 and 2006-11-17:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-11-16+04&maxdate=2006-11-17+06&cvsroot=%2Fcvsroot
I guess a regression from bug 354694.
The strange thing is, I wouldn't expect to tee a button with the testcase at all, because it should have been removed by the script. (that doesn't seem to be a regression, I can see that also in Mozilla1.7.13).

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

The previous one didn't crash online, this one should crash online when right-clicking on the button.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Add back the strange if (domEvent) check which used to be there

It used to look like this:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/content/html/content/src/nsHTMLButtonElement.cpp&rev=1.149&mark=430-432#430

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 258150 [details] [diff] [review]
Add back the strange if (domEvent) check which used to be there

r+sr=jst