373493 - Thunderbird 2.0 Account Manager window needs resizing

Status: RESOLVED FIXED

(Mozilla Localizations :: es-ES / Spanish, defect)

Description

[RickieES aka Ricardo Palomares]

While reviewing Thunderbird 2.0 in Windows, I noticed the account manager window is too wide (and tall). We had a really enlarged dimensions for this window (width: 75em, height: 55em), so I've been playing with these values.

Comment 1

[RickieES aka Ricardo Palomares]

Attachment: Adjustments in size for es-ES account manager window

BTW, I could shorten even more the window size to the en-US values if there was three entities, one for Windows, one for Linux (which needs at least 65em) and the existing for Mac OS X.

Comment 2

[Scott MacGregor]

Comment on attachment 258146 [details] [diff] [review]
Adjustments in size for es-ES account manager window

Ricardo, we haven't tagged the branch for tb2 yet so you can still land this if you get it soon. But please be sure the sizes work on windows, linux and mac as we probably won't be able to take another change to adjust it again if we go too small :)

Comment 3

[RickieES aka Ricardo Palomares]

(In reply to comment #2)
> (From update of attachment 258146 [details] [diff] [review])
> Ricardo, we haven't tagged the branch for tb2 yet so you can still land this if
> you get it soon. But please be sure the sizes work on windows, linux and mac as
> we probably won't be able to take another change to adjust it again if we go
> too small :)
> 


I can't test on Mac, but as the change on it is to get the window taller to match original en-US values, I guess we won't have a problem there...

Regarding Linux and Windows, the width: 65em fits both Windows and Linux, without being excessively wide in Windows and being fine in Linux (I've been testing updating the file in es-ES.jar before actually going with the change). The height works OK for both, so I've committed the updated file (I hope Axel doesn't correct me, I feel like having two bosses here). :-)

Comment 4

[RickieES aka Ricardo Palomares]

Attachment: Patch to make account manager window in Mac OS X wider.

After seeing other teams patch for Mac OS X, and relating their proposed width in Mac vs. Windows to the width I've set for Windows, I feel that es-ES needs more width in the account manager for Mac OS X, too.

Comment 5

[Scott MacGregor]

Comment on attachment 258246 [details] [diff] [review]
Patch to make account manager window in Mac OS X wider.

approving as we haven't tagged for tb2 yet. Please land this ASAP, thanks.

Comment 6

[RickieES aka Ricardo Palomares]

(In reply to comment #5)
> (From update of attachment 258246 [details] [diff] [review])
> approving as we haven't tagged for tb2 yet. Please land this ASAP, thanks.
> 


Done, thanks.

Comment 7

[RickieES aka Ricardo Palomares]

Mac OS X user reports this is fixed now.