37350 - err handling in install failure (win installer)

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect, P4)

Description

[Cathleen]

1.) deletes error xpi file

    In case of corrupted download, which causes install to fail, we need to 
    delete that particular xpi file.  Thus, we give users a chance to 
    re-download that particular xpi file on the next try (on install).
    Currently, users are re-trying to install again with corrupted xpi file,
    since we leave corrupted .xpi on their disk.

2.) define crucial components in config.ini, and proceed/stop install 
    appropriately if err happens

    Crucial components are .xpi files, which after installation, that give users
    a minimal workable Seamonkey running on their desktop.

    a) If install fails during installing a crucial component, such as xpcom or 
       browser, we stop the entire installation process.  Otherwise, users end 
       up with partial install on their machines that don't work.

    b) If install fails during installing a non-crucial component, such as mail,
       nim, psm...  we continue through installation, and provide a message 
       regarding to install error.

We can also direct users, who has a minimal working browser but with install 
error, to SmartUpdate site to get their Seamonkey fixed.

Comment 1

[Cathleen]

During bug review meeting, we decided that we should do 1) but not 2)

Basically, we should simply stop the installation if an err occur, but only 
deletes the currputed xpi file.  It doesn't take long to redo the installation, 
where as downloading part is the bottleneck which takes a long time.

Comment 2

[leger]

Putting on [nsbeta2+][5/16] radar.  This is a feature MUST complete work by 
05/16 or we may pull this feature for PR2.

Comment 3

[leger]

Putting on [nsbeta2-] radar. Removing [5/16]. Missed the Netscape 6 feature 
train.  Please set to MFuture.

Comment 4

[timeless]

:-( helpwanted.  Should I cc nobody?

Comment 5

[Daniel Veditz [:dveditz]]

Bring on nsbeta1 radar for reconsideration.

Comment 6

[Daniel Veditz [:dveditz]]

We're not doing the "crucial component" concept, and the check-summing is 
covered in another bug

Comment 7

[Sean Su]

this has been fixed.  The fix has been checked in as part of bug 66480.

It's not the CRUTIAL solution, but since we perform CRC checks on the download
.xpi files, we can now tell when an archive is corrupted before attempting to
install it.  The installer will now also attempt to redownload the failed CRC
checked files automatically.

Comment 8

[Grace Bush]

verified in build 2000020904
removed xpi file- was detected by err handler