373528 - Disclosure button in Sunbird event details dialog has wrong accesskey

Status: VERIFIED FIXED

(Mozilla Localizations :: nb-NO / Norwegian Bokmål, defect)

Description

[Håvard Mork]

Regarding Sunbird 0.5pre event details dialog:

Disclosure button has accesskey "I" for nb-NO. This value is specified in dialog.properties in toolkit. Button labels are either "Mer" or "Mindre" in nb-NO, which creates accesskey fallback parenthesis for the former label.

I'd like to change disclosure accesskey to "M" for nb-NO. Retaining value "I" makes no sense for nb-NO. I have tested Sunbird by manually replacing accesskey-disclosure to "M" in chrome/nb-NO.jar, and it seems to do the trick for the event dialog.

Comment 1

[Håvard Mork]

Attachment: accesskey-disclosure fix for nb-NO

Comment 2

[Axel Hecht [:Pike]]

I found at least one other use, it's in the cookieAcceptDialog, http://mxr.mozilla.org/mozilla1.8/source/toolkit/components/cookie/content/cookieAcceptDialog.xul

Can you check that that's not conflicting?

Comment 3

[Axel Hecht [:Pike]]

PS: Here's the mxr search I did:

http://mxr.mozilla.org/mozilla1.8/search?string=disclosure&find=%5C.xul%24&findi=&filter=&tree=mozilla1.8

Comment 4

[Håvard Mork]

Cookie accept dialog does not conflict. It displays labels "Vis _detaljer", "Skjul _detaljer" in Firefox. Access key is explicitly set in a DTD:
http://mxr.mozilla.org/mozilla1.8/source/toolkit/components/cookie/content/cookieAcceptDialog.js#93

Comment 5

[Stefan Sitter [:ssitter]]

Should this be fixed for Sunbird/Lightning 0.5 release? 
If yes please mark it blocking Bug 375873.

Comment 6

[Håvard Mork]

If the event edit dialog stays the same for the upcoming release, that would be preferred, yes.

Comment 7

[Axel Hecht [:Pike]]

Comment on attachment 258189 [details] [diff] [review]
accesskey-disclosure fix for nb-NO

[nb-NO] accesskey fix approved, please use the fixed1.8.1.4 and verified1.8.1.4 keywords to track the landing and testing

Comment 8

[Håvard Mork]

Change landed on l10n branch at Thu Mar 29 22:31:27 CEST 2007.
/l10n/l10n/nb-NO/toolkit/chrome/global/dialog.properties

Will do relevant testing of sb/tb/ff tomorrow.
Thanks!