373573 - SMTP server dropdown doesn't play nicely with Use Default Server

Status: RESOLVED FIXED

(MailNews Core :: Account Manager, defect)

Description

[Rod Whiteley]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2
Build Identifier: Thunderbird 2.0pre (20070311)

In the Identity Settings dialog for a default identity, changing the Outgoing Server (SMTP) choice appears to have no effect.  This is because the change is not picked up by the Account Settings dialog, so that pressing OK there backs out the change.

Reproducible: Always

Steps to Reproduce:
1. Go to Account Settings.
2. Ensure that the Outgoing Server (SMTP) page lists more than one server.
3. Select an account, press its Manage Identities... button, select the account's default identity, press the Edit... button.
4. In the Identity Settings dialog, change the Outgoing Server (SMTP) choice, and press OK to close the dialog.
5. Press OK to close the Identities for [account] dialog.
6. Press OK to close the Account Settings.

Actual Results:  
The SMTP server does not change. 

Expected Results:  
The SMTP server should change to the server you selected.

This appears to happen because in am-identity-edit.js, the function initIdentityValues does not initialize the SMTP server field.  Adding the following line to the end of that function seems to cure the problem:

document.getElementById('identity.smtpServerKey').value = identity.smtpServerKey;

Comment 1

[Magnus Melin [:mkmelin]]

WFM on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.3pre) Gecko/20070312 Thunderbird/2.0pre ID:2007031203

Comment 2

[Mike Cowperthwaite]

This WFM too, and has every time I've tried to reproduce it over the last two years; but there are a number of people who see this.

Comment 3

[Mike Cowperthwaite]

Sorry, I'm an idiot; that comment was intended for a different bug.

Comment 4

[Mike Cowperthwaite]

*This* bug, I can reproduce.  Good catch!

Comment 5

[N.R.Kashivishwanathan]

Attachment: random unrelated crap

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 276971 [details]
random unrelated crap

Please don't abuse bugzilla flags.

Comment 7

[Magnus Melin [:mkmelin]]

The original symptoms have changed. Now if you set "Use Default", you will get a very thin dropdown.

Comment 8

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Make Use Default work.

(redirectorType is long gone)

Comment 9

[[e-mail]]

Comment on attachment 398949 [details] [diff] [review]
proposed fix

> function loadSMTPServerList()
> {
>-  var smtpService = Components.classes["@mozilla.org/messengercompose/smtp;1"].getService(Components.interfaces.nsISmtpService);
>-  fillSmtpServers(document.getElementById('identity.smtpServerKey'), smtpService.smtpServers, smtpService.defaultServer);
>+  var smtpService = Components.classes["@mozilla.org/messengercompose/smtp;1"]
>+                              .getService(Components.interfaces.nsISmtpService);
>+  fillSmtpServers(document.getElementById("identity.smtpServerKey"),
>+                  smtpService.smtpServers, smtpService.defaultServer);
> }
> 
> function fillSmtpServers(smtpServerList, servers, defaultServer)
> {
Bah, we can't share this with am-smtp.js due to global scope "pollution" :-(

Comment 10

[Karsten Düsterloh]

Comment on attachment 398949 [details] [diff] [review]
proposed fix

>+  fillSmtpServers(document.getElementById("identity.smtpServerKey"),
>+                  smtpService.smtpServers, smtpService.defaultServer);
> }
> 
> function fillSmtpServers(smtpServerList, servers, defaultServer)

If we have only one caller and can't share the function anyway, what's the point of having a separate fillSmtpServers at all?
If you can't imagine one either, just kill it. ;-)

Comment 11

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v2 (for checkin)

Carrying forward r=mnyromyr, sr=neil

Comment 12

[Magnus Melin [:mkmelin]]

changeset:   3838:c9b5c02830e5
http://hg.mozilla.org/comm-central/index.cgi/rev/c9b5c02830e5

->FIXED