Closed
Bug 37359
Opened 25 years ago
Closed 23 years ago
Print Preview Broken (in viewer app)[viewer][print]
Categories
(Core :: DOM: Navigation, defect, P1)
Core
DOM: Navigation
Tracking
()
VERIFIED
WONTFIX
Future
People
(Reporter: troy, Assigned: dcone)
References
Details
(Keywords: embed, regression, Whiteboard: [nsbeta2-][nsbeta3-] have fix in tree, viewer only, no risk to mozilla)
Print preview in viewer is broken again. We need print preview to work in order
to fix printing bugs...
NTDLL! 77f9f9df()
nsDebug::Assertion(const char * 0x00443d10 `string', const char * 0x00443d54
`string', const char * 0x00443d64 `string', int 621) line 191 + 13 bytes
nsDebug::PreCondition(const char * 0x00443d10 `string', const char * 0x00443d54
`string', const char * 0x00443d64 `string', int 621) line 284 + 21 bytes
nsCOMPtr<nsIBaseWindow>::operator->() line 621 + 34 bytes
nsBrowserWindow::Init(nsIAppShell * 0x00cf7440, const nsRect & {...}, unsigned
int 16, int 1, nsIDocumentViewer * 0x0267b4f0, nsIPresContext * 0x00d408a0) line
1503 + 49 bytes
nsBrowserWindow::ShowPrintPreview(int 40035) line 2423
nsBrowserWindow::DispatchMenuItem(int 40035) line 870
nsNativeBrowserWindow::DispatchMenuItem(int 40035) line 145
HandleBrowserEvent(nsGUIEvent * 0x0012fd88) line 597 + 21 bytes
nsWindow::DispatchEvent(nsWindow * const 0x00c99a44, nsGUIEvent * 0x0012fd88,
nsEventStatus & nsEventStatus_eIgnore) line 511 + 10 bytes
nsWindow::DispatchWindowEvent(nsGUIEvent * 0x0012fd88) line 532
nsWindow::ProcessMessage(unsigned int 273, unsigned int 40035, long 0, long *
0x0012fe2c) line 2161 + 21 bytes
nsWindow::WindowProc(HWND__ * 0x000b02e6, unsigned int 273, unsigned int 40035,
long 0) line 740 + 27 bytes
USER32! 77e13eb0()
USER32! 77e1401a()
USER32! 77e192da()
main(int 1, char * * 0x00ab7400) line 157 + 11 bytes
mainCRTStartup() line 338 + 17 bytes
K
Comment 2•25 years ago
|
||
viewer crashes on Print Preview on mac, win32, linux for today's tree.
With travis (and troy) departing, this needs a new owner. Passing to
dcone@netscape.com to find the right home for this bug.
Assignee: travis → dcone
QA Contact: travis → shrir
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•25 years ago
|
Target Milestone: --- → M16
Assignee | ||
Updated•25 years ago
|
Target Milestone: M16 → M17
Assignee | ||
Comment 3•25 years ago
|
||
This should not be dogfood, this is a viewer bug.
Comment 4•25 years ago
|
||
Removing [dogfood+], per dcone above, for PDT reconsideration.
Summary: Print Preview Broken → Print Preview Broken (in viewer app)
Whiteboard: [dogfood+]
Comment 5•25 years ago
|
||
marking all, failed on linux & winNT today.
OS: Windows NT → All
Hardware: PC → All
Comment 6•25 years ago
|
||
[dogfood-]. If this doesn't stop dcone, we assume no one in Gecko is blocked by
this. Please remove the minus if someone is blocked by this.
Whiteboard: [dogfood-]
Assignee | ||
Comment 7•25 years ago
|
||
Patch to fix this bug.. I will check in as soon as the tree opens.
Index: nsBrowserWindow.cpp
===================================================================
RCS file: /cvsroot/mozilla/webshell/tests/viewer/nsBrowserWindow.cpp,v
retrieving revision 3.328
diff -r3.328 nsBrowserWindow.cpp
1503c1503
< nsCOMPtr<nsIDocumentLoader> docLoader;
---
>
1507a1508,1511
>
> mWebBrowser = do_CreateInstance(NS_WEBBROWSER_PROGID);
> NS_ENSURE_TRUE(mWebBrowser, NS_ERROR_FAILURE);
>
1509a1514,1517
> NS_ENSURE_SUCCESS(EnsureWebBrowserChrome(),NS_ERROR_FAILURE);
> mWebBrowser->SetTopLevelWindow(mWebBrowserChrome);
>
>
1510a1519,1521
> mWebBrowser->GetDocShell(&mDocShell);
> mDocShell->SetAllowPlugins(aAllowPlugins);
> nsCOMPtr<nsIDocumentLoader> docLoader;
1512a1524
>
1516a1529,1531
> webBrowserWin->SetVisibility(PR_TRUE);
>
>
1545a1561
> #if 0
1551a1568
> #endif
Assignee | ||
Updated•25 years ago
|
Whiteboard: [dogfood-] → [dogfood-] have fix in tree
Assignee | ||
Updated•25 years ago
|
Comment 8•25 years ago
|
||
nsbeta2-, would not hold beta for this. Who is blocked?
Whiteboard: have fix in tree, viewer only, no risk to mozilla → [nsbeta2-] have fix in tree, viewer only, no risk to mozilla
Assignee | ||
Updated•25 years ago
|
Comment 9•25 years ago
|
||
Setting to nsbeta3-.
Whiteboard: [nsbeta2-] have fix in tree, viewer only, no risk to mozilla → [nsbeta2-][nsbeta3-] have fix in tree, viewer only, no risk to mozilla
Comment 10•25 years ago
|
||
Adding nsbeta2 keyword to bugs with nsbeta2 triage value in status field so the
queries don't get screwed up
Assignee | ||
Comment 11•25 years ago
|
||
This bug has been marked future because we have determined that it is not
critical for netscape 6.0. If you feel this is an error, or if it blocks your
work in some way -- please attach your concern to the bug for reconsideration.
Target Milestone: M17 → Future
Comment 12•24 years ago
|
||
I gave this a vote because it was the show stopper when my collegues at work
compared mozilla to IE5.
I'd like to see anything but 'Future' in the target milestone.
Well, M30 wouldn't be nice either :)
Comment 13•24 years ago
|
||
The lack of a Print Preview facility kept me on Netscape 4.x instead of going
over to the dark side (IE). IE's new(ish) Print Preview fixed one of its few
remaining weaknesses.
Given how flaky printing in in M18 (weird layouts, crashes, etc.) an effective
Print Preview function is essential!
![]() |
||
Comment 14•24 years ago
|
||
Is this a duplicate of bug 20943? Or just dependent on it?
Assignee | ||
Comment 15•24 years ago
|
||
update my keywords
Summary: Print Preview Broken (in viewer app) → Print Preview Broken (in viewer app)[viewer][print]
Updated•24 years ago
|
Keywords: mozilla1.0
Comment 16•23 years ago
|
||
This is the old implementation where the Print Preview pops up in a separate
window. It is unclear exactly what we are going to do with PP. But this old impl
won't be fixed - marking as "Won't Fix"
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•