373733 - Wrong open-quote & close-quote appear in RTL page

Status: NEW

(Core :: Layout: Text and Fonts, defect)

Description

[dror3go]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070312 Minefield/3.0a3pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070312 Minefield/3.0a3pre

In a RTL page with CSS's :before and :after to add content, the wrong open-quote and close-quote appear.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[dror3go]

Attachment: testcase of the problem

Added testcase of the bug.
Note that Firefox 2 doesn't have this bug.

Comment 2

[Simon Montagu :smontagu]

This looks like a special case of bug 16206, but there are complications in RTL text. See Bug 345156 comment 21 and following.

Comment 3

[dror3go]

Releasing Firefox 3 with this not fixed is a regression from Firefox 2. Should this bug block 1.9?

Comment 4

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).

Comment 5

[fantasai]

Would calculating the open-quote and close-quote values against the 'direction' property solve this?

Comment 6

[Amir Aharoni]

For Hebrew there are several possibilities:

1. The very best: („) for opening and (”) for closing. For nested quotes: (‚) for opening and (’) for closing.

2. Fine: (”) for opening and closing, (’) for nested opening and closing.

3. OK, and de-facto most common online: (") for opening and closing, (') for nested opening and closing.

Number 1 is the best practice recommended by The Academy of the Hebrew Language. Numbers 2 and 3 are acceptable, too.

Comment 7

[Tomer Cohen :tomer]

Attachment: proposed solution

(In reply to comment #5)
> Would calculating the open-quote and close-quote values against the
> 'direction' property solve this?
I think this will solve this.

Attached is an HTML example that show how it behave and how we can solve this. I'm not sure if this is exactly the way we should implement it, but this is my try. I've used arrows instead of real quotes in order to make it more visual to us, but it should work the same with {open,close}-quotes.

Comment 8

[Tomer Cohen :tomer]

Comment on attachment 530827 [details]
proposed solution

I've forgot to mention that my solution is not complete unless we can do something to workaround cases when the direction is mentioned on the stylesheet and not on HTML… (bug 562169, probably)