Closed Bug 373888 Opened 17 years ago Closed 17 years ago

code cleanup: use viewElem property in decorated views

Categories

(Calendar :: Calendar Frontend, defect)

Product:
Calendar
Component:
Calendar Frontend
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: thomas.benisch, Assigned: mschroeder)

Details

Attachments

(1 file, 1 obsolete file)

Patch v2
19.90 KB, patch
michael.buettner
: first-review+
Details | Diff | Splinter Review 
The calendar-decorated-base-view binding
(calendar/base/content/calendar-decorated-base.xml)
provides a viewElem property which should be used instead of calling
document.getAnonymousElementByAttribute(this, "anonid", "view-element")
in this and all derived bindings.

The affected files are:
calendar\base\content\calendar-decorated-base.xml
calendar\base\content\calendar-decorated-day-view.xml
calendar\base\content\calendar-decorated-month-view.xml
calendar\base\content\calendar-decorated-multiweek-view.xml
calendar\base\content\calendar-decorated-week-view.xml
This is a follow-up issue of Bug 349520.
Attached patch Patch v1 (obsolete) — — Splinter Review 
Assignee: thomas.benisch → mschroeder
Status: NEW → ASSIGNED

        Attachment #259317 -
        Flags: first-review?(michael.buettner)

    
    

    
  
Comment on attachment 259317 [details] [diff] [review]
Patch v1

I missed some spots.

        Attachment #259317 -
        Attachment is obsolete: true

        Attachment #259317 -
        Flags: first-review?(michael.buettner)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v2
        — 
          — Splinter Review
      

    


  
Second try.

        Attachment #259321 -
        Flags: first-review?(michael.buettner)

    
    

    
  
Comment on attachment 259321 [details] [diff] [review]
Patch v2

looks good, thanks for the patch ;-) r=mickey

        Attachment #259321 -
        Flags: first-review?(michael.buettner) → first-review+

    
    

    
  
Marking as 'needs checkin', since we want to hold this off until 0.5 is out of the door...
Whiteboard: [needs checkin]
Whiteboard: [needs checkin] → [checkin needed after 0.5]

    
    

    
  
Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
OS: Windows Server 2003 → All
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [checkin needed after 0.5]
Target Milestone: --- → 0.7

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: