Closed
Bug 373888
Opened 19 years ago
Closed 19 years ago
code cleanup: use viewElem property in decorated views
Categories
(Calendar :: Calendar Frontend, defect)
Calendar
Calendar Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
0.7
People
(Reporter: thomas.benisch, Assigned: mschroeder)
Details
Attachments
(1 file, 1 obsolete file)
|
19.90 KB,
patch
|
michael.buettner
:
first-review+
|
Details | Diff | Splinter Review |
The calendar-decorated-base-view binding
(calendar/base/content/calendar-decorated-base.xml)
provides a viewElem property which should be used instead of calling
document.getAnonymousElementByAttribute(this, "anonid", "view-element")
in this and all derived bindings.
The affected files are:
calendar\base\content\calendar-decorated-base.xml
calendar\base\content\calendar-decorated-day-view.xml
calendar\base\content\calendar-decorated-month-view.xml
calendar\base\content\calendar-decorated-multiweek-view.xml
calendar\base\content\calendar-decorated-week-view.xml
|
Reporter | |
Comment 1•19 years ago
|
||
This is a follow-up issue of Bug 349520.
|
Assignee | |
Comment 2•19 years ago
|
||
Assignee: thomas.benisch → mschroeder
Status: NEW → ASSIGNED
Attachment #259317 -
Flags: first-review?(michael.buettner)
|
|
Assignee | |
Comment 3•19 years ago
|
||
Comment on attachment 259317 [details] [diff] [review]
Patch v1
I missed some spots.
Attachment #259317 -
Attachment is obsolete: true
Attachment #259317 -
Flags: first-review?(michael.buettner)
|
|
Assignee | |
Comment 4•19 years ago
|
||
Second try.
Attachment #259321 -
Flags: first-review?(michael.buettner)
|
|
||
Comment 5•19 years ago
|
||
Comment on attachment 259321 [details] [diff] [review]
Patch v2
looks good, thanks for the patch ;-) r=mickey
Attachment #259321 -
Flags: first-review?(michael.buettner) → first-review+
|
|
||
Comment 6•19 years ago
|
||
Marking as 'needs checkin', since we want to hold this off until 0.5 is out of the door...
Whiteboard: [needs checkin]
|
||
Updated•19 years ago
|
Whiteboard: [needs checkin] → [checkin needed after 0.5]
|
||
Comment 7•19 years ago
|
||
Checked in on HEAD and MOZILLA_1_8_BRANCH
-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
OS: Windows Server 2003 → All
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [checkin needed after 0.5]
Target Milestone: --- → 0.7
You need to log in
before you can comment on or make changes to this bug.
Description
•