373949 - Crash restoration logic is wrong

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Stuart Morgan]

The code to not show the post-crash UI when there's no saved session introduced a bug that totally breaks our crash detection for people that don't turn session saving on:
1) Quit normally; PreviousSessionTerminatedNormally is now YES, and there's no saved session (since we delete it on normal quit when the pref is off)
2) Relaunch, and since there is no stored state we don't check for a crash, so we never set PreviousSessionTerminatedNormally back to NO
3) Crash
4) Be sad

I'll post a fix tonight.

Comment 2

[Stuart Morgan]

Attachment: fix

Having the update of the defaults done as a side effect of checking it makes it too easy to make the mistake I made, and solved a problem we don't have (being able to check it more than once), so this just moves the existing update logic into applicationDidFinishLaunching.

Comment 3

[Sean Murphy]

Comment on attachment 258621 [details] [diff] [review]
fix

r=me; Thanks for clearing this up, and sorry for missing the problem the first place.

Comment 4

[Stuart Morgan]

Landed on trunk and MOZILLA_1_8_BRANCH.