373952 - CJK native font names are not recognized on non-CJK Windows

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Win32, defect)

Description

[Jungshik Shin]

This issue was supposed to be fixed in bug 231426. It's partly solved in that it works well across CJK locales (Korean fonts on Japanese Windows, SC fonts on K Windows) where the codepage has 3 digits.  However, it does not work on English locale and other locales where the codepage has 4 digits. 

The following does not work if gCodePageStr has 4-digit-long codepage part (e.g. ".cp1252") while aWinName ends with '.cp932' (949,950,936). 

+      else {
+        // font codepage != current codepage => map to the ASCII name
+        aWinName.Truncate(aWinName.Length() - gCodepageStr->Length());
+      }

Because fontNamemap.properties only has 3 digit codepages and it'll never have other codepages than it currently has (this is only used by branch), we can just use '6' in place of 'gCodepageStr->Length()'.

Comment 1

[Jungshik Shin]

Attachment: patch (includes Vista fonts)

asking for r/sr and a.

The risk is very low and this should have been done properly in the original patch (spring 2005). It's my fault to overlook this problem. 

While fixing this problem, I also added 4 Vista fonts to the mapping table.

Comment 2

[Jungshik Shin]

Attachment: patch ('typo fixed' in Vista font name mapping)

I tested the previous patch on Vista and found a couple of typos in Vista font mapping. 

Risk should be very low.

Comment 3

[Jungshik Shin]

Attachment: test case

this is the same as attachment 173506 [details] to bug 231426 except that a typo in 'Gungsuh' (I omitted 'g' before 's') is fixed and Vista fonts are added.

Comment 4

[rbs]

Comment on attachment 258940 [details] [diff] [review]
patch ('typo fixed' in Vista font name mapping)

sr=rbs

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 258940 [details] [diff] [review]
patch ('typo fixed' in Vista font name mapping)

Moving approval req., 1813 was a re-spin release

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 258940 [details] [diff] [review]
patch ('typo fixed' in Vista font name mapping)

approved for 1.8.1.4, a=dveditz for release-drivers

Comment 7

[Jungshik Shin]

checked into 1.8.1.x branch

Comment 8

[Carsten Book [:Tomcat]]

verified fixed 1.8.1.4 using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.4pre) Gecko/2007042805 BonEcho/2.0.0.4pre / the cjk native font names are now recognized. Adding verified keyword