374036 - Japanese builds (both Firefox and Thunderbird) should bundle English spell-check dictionary

Status: VERIFIED FIXED

(Mozilla Localizations :: ja / Japanese, defect)

Description

[Kohei Yoshino [:kohei]]

The English dictionary comes with Thunderbird 1.5. Japanese users might be confused if Thunderbird 2 won't have the dictionary.

Thunderbird (zh-TW) has already bundled it, so we need:

1. Copy the 'spellcheck' directory from
http://lxr.mozilla.org/l10n-mozilla1.8/source/zh-TW/extensions/

2. Add the following line to ja/mail/all-l10n.js:
pref("spellchecker.dictionary", "en-US");

Comment 1

[Scott MacGregor]

If you want to slip this into thunderbird 2 it needs to happen really soon. Tagging for Thunderbird 2 could begin as early as Wednesday morning (PDT).

Comment 2

[dynamis (Tomoya ASAI)]

Spell check dictionary cannot be bundled only for Thunderbird.
So we want to add en-US dictionary for both Japanese Firefox(2.0.0.4 or later) and Thunderbird(2.0 or later).

I request approval to copy dictionary file from en-US
http://lxr.mozilla.org/mozilla1.8/source/extensions/spellcheck/locales/en-US/myspell/
to
http://lxr.mozilla.org/l10n-mozilla1.8/source/ja/extensions/spellcheck/myspell/
and add spellchecker.dictionary pref to mail/all-l10n.js.
# I'll attach the patch.

Comment 3

[dynamis (Tomoya ASAI)]

Attachment: add spellchecker.dictionary pref in all-l10n.js

Dictionary files are completely same as en-US and I'll not attach the file.
Once you approve this patch, I'll commit dictionary files too.

Comment 4

[Kohei Yoshino [:kohei]]

(In reply to comment #3)
> Created an attachment (id=259112) [details]
> add spellchecker.dictionary pref in all-l10n.js

dynamis: for Firefox, add the pref in browser/firefox-l10n.js too.
http://lxr.mozilla.org/l10n-mozilla1.8/source/ja/browser/firefox-l10n.js
http://lxr.mozilla.org/l10n-mozilla1.8/source/ja-JP-mac/browser/firefox-l10n.js

Comment 5

[dynamis (Tomoya ASAI)]

(In reply to comment #4)
> dynamis: for Firefox, add the pref in browser/firefox-l10n.js too.

As far as I test, Thunderbird must have spellchecker.dictionary pref to use en-US dictionary but on the other hand Firefox use en-US dictionary without the pref when dictionary files are exists.
# Firefox will automatically set the pref when we view the textbox first.

So I didn't included change for firefox-l10n.js in the patch.
Is this wrong and should we add to firefox-l10n.js too?

Comment 6

[Kohei Yoshino [:kohei]]

(In reply to comment #5)
Thanks, I understand. Ignore my comment 4.

Comment 7

[Scott MacGregor]

Comment on attachment 259112 [details] [diff] [review]
add spellchecker.dictionary pref in all-l10n.js

Hey guys, we had discussion thread on release drivers with Gen about this. Because the change impacts Firefox as well and we are a few hours away from starting the RC packaging, we all agreed it's too late for this. 

We can come back to this in a point release if we can get sign off from the Firefox stakeholders since the change effects both products.

In the mean time, I think we should add a note to the japanese release notes for thunderbird 2 so users who are looking for the english dictionary can find it. Asai, is that something you can help us with?

Thanks!

Comment 8

[Kohei Yoshino [:kohei]]

Scott, sorry for the last-minute request. We'll add this bug as a known problem on our localized 2.0 release notes.

Comment 9

[Gen Kanai [:gen]]

Thanks for the consideration everyone.  We do want to see this functionality back in TB2 ja-JP at the next point release so we'd appreciate the support of the FX team to enable that to happen.

Comment 10

[Axel Hecht [:Pike]]

Unhooking this from late-l10n tracking, I don't think it ever was "late-l10n", really.

Comment 11

[kuro68k]

Surely the en-GB dictionary should be included instead of the US one. Japan uses International English, which has similar spellings to British English. I worked in Japan for a number of years and can confirm this.

At the very least, both sets of spellings should be accepted to avoid confusing poor non-native speakers. Perhaps we need a new mixed spelling dictionary...

Comment 12

[Kohei Yoshino [:kohei]]

I'd like to see this in Thunderbird 3. Currently, the following locales bundle a dictionary in their own languages:

el, fr, hu, id, ka, lt, lv, mk, nl, pl, pl, pt-PT, ro, ru, sk, sr, sv-SE, ta, uk

Can we just copy the en-US directory and set spellchecker.dictionary pref to en-US?

Comment 13

[Kohei Yoshino [:kohei]]

Also wanted‑firefox3.1

Comment 14

[Axel Hecht [:Pike]]

Nobody is going to triage the wanted flags here, unsetting those.

Comment 15

[Atsushi Sakai]

(In reply to comment #11)
> Surely the en-GB dictionary should be included instead of the US one. Japan
> uses International English, which has similar spellings to British English.

We Japanese prefer US English rather than British English, e.g. we spell "color", "center" and so on; not "colour" or "centre."

(In reply to comment #12)
> Can we just copy the en-US directory and set spellchecker.dictionary pref to
> en-US?

Fixed.
http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/ja/file/e7a36f480c75
http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/ja-JP-mac/file/fa0b7e10e445

Comment 16

[Atsushi Sakai]

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.1b3pre) Gecko/20090216 Shredder/3.0b2pre

Comment 17

[Kohei Yoshino [:kohei]]

Verified with Shiretoko too. Thanks!

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; ja; rv:1.9.1b3pre) Gecko/20090218 Shiretoko/3.1b3pre

Comment 18

[Atsushi Sakai]

(In reply to comment #17)
> Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; ja; rv:1.9.1b3pre)
> Gecko/20090218 Shiretoko/3.1b3pre

On Mac, please use ja-JP-mac instead.

Comment 19

[Kohei Yoshino [:kohei]]

(In reply to comment #18)
> On Mac, please use ja-JP-mac instead.

Hm, somehow I've downloaded a ja build. Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; ja-JP-mac; rv:1.9.1b3pre) Gecko/20090218 Shiretoko/3.1b3pre

A reminder: in the future, we have to maintain the dictionary manually when the original one has been updated.