374089 - Add a pref for the Accept header for images

Status: RESOLVED WONTFIX

(Core :: Graphics: ImageLib, enhancement)

Description

[Mike Hommey [:glandium]]

Please add a preference for the Accept request header for images, as set in imageLoader's NewImageChannel, to be customized, as it is currently possible for normal HTTP requests with network.http.accept_default.

Comment 1

[Jesse Ruderman]

Should this be a single pref?  Or should it be something similar to general.useragent.extra.*, so each extension that adds to the Accept header can do so by having a default pref?

Comment 2

[Mike Hommey [:glandium]]

That's indeed a good question. I have no strong opinion on that, but the same rationale could be applied to network.http.accept.default, too...

As for implementation details, do you think it would be best to query the prefservice each time or add a member to the class, set it to the value of the pref at instanciation time, and add an observer to modify its value when the pref change ?

Comment 3

[Joe Drew (not getting mail)]

We should totally take a patch - I might even write one - but this doesn't block the release.

Comment 4

[Masatoshi Kimura [:emk]]

Image decoders and User-Agent strings are no longer extensible. Is this bug still valid?

Comment 5

[Bobby Holley (:bholley)]

(In reply to comment #4)
> Image decoders and User-Agent strings are no longer extensible. Is this bug
> still valid?

I believe that it is not.

Comment 6

[Mike Hommey [:glandium]]

For those like me who wondered why: https://bugzilla.mozilla.org/show_bug.cgi?id=513681#c7