374112 - This use of E4X setName causes "Assertion failure: !IS_EMPTY(nameqn->uri)"

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

js> <a/>.setName(<b/>.name());
Assertion failure: !IS_EMPTY(nameqn->uri), at jsxml.c:7009

Seems harmless in opt.

Comment 1

[Igor Bukanov]

Attachment: Fix v1

The assertion reflects the assumption that an empty namespace uri must not have null prefix. The only place that I have found where this is violated is during parsing in ParseNodeToQName where prefix is set to null for any uri. The patch fixes that. 

Surprisingly there are no regressions with the patch against the testsuite. But on the other hand this bug reflects precisely the fact that xml prefix coverage in the suite is close to zero.

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 259031 [details] [diff] [review]
Fix v1

Thanks, r=me.

/be

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 259031 [details] [diff] [review]
Fix v1

Super-safe fix.

/be

Comment 4

[Igor Bukanov]

I committed the patch from comment 1 to the trunk:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.150; previous revision: 3.149
done

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 259031 [details] [diff] [review]
Fix v1

approved for 1.8.0.12 and 1.8.1.4, a=dveditz for release-drivers

Comment 6

[Bob Clary [:bc] (inactive)]

Checking in regress-374112.js;
/cvsroot/mozilla/js/tests/e4x/Regress/regress-374112.js,v  <--  regress-374112.js
initial revision: 1.1

Comment 7

[Igor Bukanov]

I committed the patch from comment 1 to MOZILLA_1_8_BRANCH:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.50.2.63; previous revision: 3.50.2.62
done

Comment 8

[Igor Bukanov]

I committed the patch from comment 1 to MOZILLA_1_8_0_BRANCH:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.50.2.15.2.33; previous revision: 3.50.2.15.2.32
done

Comment 9

[Bob Clary [:bc] (inactive)]

verified fixed linux, windows, mac* 1.8.0, 1.8.1, 1.9.0 shell 20070406