374155 - Switch strong pointers to weak ones where it is safe to do so

Status: RESOLVED WONTFIX

(Core :: General, defect)

Description

[(dormant account)]

Attachment: simplest case for nsPIDOMWindow.h

See Strong reference domination at http://wiki.mozilla.org/DeHydra for a sample problem.

Comment 1

[(dormant account)]

Attachment: nsNetUtil.h unreffing

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

You haven't changed GetNotificationCallbacks or introduced a non-addrefing version, so this just leaks, right? GetNotificationCallbacks adds a ref and nothing releases it.

Comment 3

[(dormant account)]

(In reply to comment #2)
> You haven't changed GetNotificationCallbacks or introduced a non-addrefing
> version, so this just leaks, right? GetNotificationCallbacks adds a ref and
> nothing releases it.
> 

Looks like I did not understand how you want to proceed with this. Initially I thought that this was rewritable at callsites, but that does not seem to be the case since the callee is doing AddRef. Or am I overlooking something?
It's certainly possible to examine all call sites in the mozilla src(minus the usual blindness caused by CPP) to build a list of getter functions to rewrite and then rewrite them(easy part). However this wont work for any functions that are visible to the outside world since we aren't in control of that code. Also not sure if that's worth the hassle to save 2 ref count operations.
Another approach is to identify these cases in hot paths and do most of the work by hand. 
What's the correct way to approach this?

Comment 4

[(dormant account)]

We decided this wasn't viable. Closing old bug