374166 - history-on-places regression, fail to set grouping

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

history-on-places regression, fail to set grouping

thanks to mano for spotting this.
I get:

JavaScript error: chrome://browser/content/places/history-panel.js, line 102: gHistoryTree.getResult() has no properties

this is more fall out from my fix for bug #373719

here comes a fix.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 2

[Asaf Romano (gone)]

Comment on attachment 258745 [details] [diff] [review]
patch

>Index: history-panel.js
>===================================================================

>     document.getElementById("byday").setAttribute("checked", "true");
> 
>   initContextMenu();
> 
>   // XXXBlake we should persist the last search value
>   // If it's empty, this will do the right thing and 
>   // just group by the old grouping.
>   // bug #359073 tracks this RFE
>-  searchHistory(gSearchBox.value);
>+  //

remove that.

>+  // on timeout because of the corresponding setTimeout()
>+  // in the places tree binding's constructor
>+  setTimeout(function() { searchHistory(gSearchBox.value); }, 0); 
>   gSearchBox.focus();

r=mano

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: patch, carrying over mano's review

Comment 4

[(not reading, please use [e-mail] instead)]

fixed.

thanks again to asaf for spotting this.

Checking in history-panel.js;
/cvsroot/mozilla/browser/components/places/content/history-panel.js,v  <--  hist
ory-panel.js
new revision: 1.11; previous revision: 1.10
done