374239 - Add debug timing code to nsCycleCollector::Collect().

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Johnny Stenback (:jst)]

Having code in place that can dump how much time we spend in various parts of cycle collection would be useful in tuning and debugging cycle collection... Patch coming up.

Comment 1

[Johnny Stenback (:jst)]

Attachment: Add time tracking code (#define COLLECT_TIME_DEBUG

This adds some trivial output about how long it takes to do various parts of the cycle collection call. #define COLLECT_TIME_DEBUG to use it.

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 258858 [details] [diff] [review]
Add time tracking code (#define COLLECT_TIME_DEBUG

>diff --git a/xpcom/base/nsCycleCollector.cpp b/xpcom/base/nsCycleCollector.cpp
>index 3c4d6d1..56213fe 100644
>--- a/xpcom/base/nsCycleCollector.cpp
>+++ b/xpcom/base/nsCycleCollector.cpp

>@@ -1646,16 +1651,35 @@ nsCycleCollector::Collect(PRUint32 aTryCollections)

>-            if (mRuntimes[i])
>+            if (mRuntimes[i]) {
>                 mRuntimes[i]->BeginCycleCollection();
>+
>+            }

No need for these changes

Comment 3

[Johnny Stenback (:jst)]

Indeed, leftovers from earlier version of this change, prior to the addition of the aTryCollections argument and the loop on that :)

Fix checked in.