374330 - Make it possible for installation templates to be text or HTML

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, enhancement)

Description

[Max Kanat-Alexander]

The next step for setup.cgi is to make it so that we can display HTML there instead of just plain text.

This means:

* setup.cgi will have to have HTML markup
* We'll have to html-escape anything we throw at the user.
* We have to be able to pick an HTML string instead of a text string
  for setup.cgi vs. checksetup.pl

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Okay, here's the first version. I'm going to do another version, though, and replace is_web with a new installation_mode called INSTALLATION_MODE_WEB. I'll also move installation_mode into Bugzilla::Install::Util.

Comment 2

[Max Kanat-Alexander]

Attachment: v2

Okay. I didn't move installation_mode into Bugzilla::Util, because I want installation_mode to continue to mean what it means. Instead, I made is_web understand Bugzilla->usage_mode for when you're running at the command line. It also works before you have all the requirements loaded, so that's nice.

Comment 3

[Max Kanat-Alexander]

Note that if we discover a performance problem, it's possible to speed up install_string by loading every hash into an arrayref, caching that arrayref, and just going though it to look for the strings.

Comment 4

[Max Kanat-Alexander]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.550; previous revision: 1.549
done
Checking in setup.cgi;
/cvsroot/mozilla/webtools/bugzilla/setup.cgi,v  <--  setup.cgi
new revision: 1.2; previous revision: 1.1
done
Checking in Bugzilla/Install/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Util.pm,v  <--  Util.pm
new revision: 1.3; previous revision: 1.2
done
RCS file: /cvsroot/mozilla/webtools/bugzilla/template/en/default/setup/strings.html.pl,v
done
Checking in template/en/default/setup/strings.html.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/setup/strings.html.pl,v  <--  strings.html.pl
initial revision: 1.1
done
Checking in template/en/default/setup/strings.txt.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/setup/strings.txt.pl,v  <--  strings.txt.pl
new revision: 1.2; previous revision: 1.1
done