374524 - Provide some UI that allows users to annotate a URI with tags

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Dietrich Ayala (:dietrich)]

This is a tracking bug for item PLCS-002d in the Firefox 3 PRD.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Not blocking on P2 items, but really-really-want! :)

Comment 2

[Steve Won (stevewon on irc)]

Hello. Here's the prototype I've been working on for taggin. There have been a few emails going back and forth, but thought it would be better to share on bugzilla.

Here's the link to the prototype if anyone wants to try it out. 

http://www.andrew.cmu.edu/user/swon/mozilla/prototypes/tag_standalone1_v3.xul

The prototype focuses mainly on the textinput<->button interaction. 
A couple of things...
1. Selected tag will be in different color from the rest of the tags
2. You can traverse through tags using left and right arrows.
3. You can also select a tag by clicking on it.
4. You can edit the tag by double-clicking on the tag or by selecting it and pressing return.
5. You can use comma, tab, or return to create a tag.
6. You can select a tag and press backspace button to remove the tag.
7. If you are at the beginning of the textinput box, pressing backspace will select the tag to the left of the cursor, and pressing backspace again will delete it.


If you get a chance to play with it, any feedback would be helpful.. thanks! =]

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(Tested on branch, slap me.)
1. Using the cursor to move between the tags disables navigation in the tag typed in (maybe use alt/ctrl + something for navigation which is not already used - if the tag is only used in the bookmark dialog, the commands for tab navigation could be used).
2. Pressing the "Insert" button while a tag is focused gives:
[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIController.doCommand}" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://global/content/globalOverlay.js :: anonymous :: line 156" data: no]
3. Left and top border are not very well to see, maybe the background of the box containing the button should be different
4. Pressing "Delete" on a tag should delete it, "Insert" should edit it (return open a tab with a list of all bookmarks containing the tab).
5. Jumping tags while switching the edited tag should be avoided.

Comment 4

[Steve Won (stevewon on irc)]

Hey. 
For #1 (if I understand your comment correctly), you can move around in the textbox (the tag being written currently). When you hit left or right at the edge of the textbox, you will navigate to another tag.
#2, there's not handler set for "Insert" button.
#4, If a tag is selected, pressing "Delete" will delete it. If you press "Return" on a selected tag, you can edit the tag.
#5, not exactly sure what you mean.

Thanks for the feedback.

Comment 5

[Steve Won (stevewon on irc)]

Attachment: Prototype (tag_standalone1_v3.xul) screenshot 1

Comment 6

[Steve Won (stevewon on irc)]

Attachment: Prototype (tag_standalone1_v3.xul) screenshot 2

Comment 7

[Steve Won (stevewon on irc)]

Attachment: Prototype xul

Comment 8

[Christine Yen]

> 5. You can use comma, tab, or return to create a tag.
When I use tab to create a tag, a new editable text field is created for the next tag but the focus jumps to the address bar, and I have to manually click back into the open textbox.

> 6. You can select a tag and press backspace button to remove the tag.
I'm testing on a trunk build on Mac OS X and doing this sends the browser back in history...

I do like how if you click a little to the right of the last created tag, the text field pops up automatically, though :)

> 7. If you are at the beginning of the textinput box, pressing backspace will
> select the tag to the left of the cursor, and pressing backspace again will
> delete it.

I... don't know why the browser's reacting the way it is to backspace, but the same problem comes up that I mentioned earlier, with the browser interpreting backspace as a back button.

Comment 9

[Steve Won (stevewon on irc)]

Hey. haha the back button<=>backspace thing happened to me too,but didn't get a chance yet to figure that out.
One way you can test it instead is save the xul file, and drag it to the browser so it's the first thing it opens... heh.

The address bar thing never happened to me though.

Comment 10

[Steve Won (stevewon on irc)]

Attachment: Tagging Extension

* Extension was tested on the Alpha 5 release.

* Setting up the extension

    1. Install the xpi file.

    2. (After restarting) Right click on toolbar and then “customize”.

    3. Find the tagging icon (titled as “Tagging UI Prototype 1″) and drag it to the toolbar.

Comment 11

[Steve Won (stevewon on irc)]

Attachment: Patch Work in Progress

**Patch wip.

I tried to use ifdef with this patch, but didn't turn out too well last time I tried (maybe I was doing something wrong). 

Also, currently just putting a span around favicon icon to click on it and get the popup up, but should change that too.

Comment 12

[Alex Faaborg [:faaborg] (Firefox UX)]

Added mockups to bug 329261 (tag selector) and bug 387485 (tag editor).

Comment 13

[Dietrich Ayala (:dietrich)]

fixed by the checkin of bug 385266.

Comment 14

[Tracy Walker [:tracy]]

verified with - Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007091304 Minefield/3.0a8pre

Comment 15

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv