374566 - CalDAV provider should provide UI when setting calendar read-only

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[Bruno Browning]

The CalDAV provider checks the calendar URL at loadtime for various DAVish problems, and currently simply throws an unlocalizable string into the error console (and sets the calendar readonly) when certain problems are found. It ought to provide better (and localizable) user feedback.

This is a followup to bug #355270

Comment 1

[Bruno Browning]

Attachment: use standard readonly alert

this removes the reports in the error console, and uses the standard read-only alert instead, with localizable strings.

I'm not sure whether this requires ui-review or not: the strings in question appear only in the normally-hidden Details area of the read-only alert.

post-0.5, obviously

Comment 2

[Matthew (lilmatt) Willis]

Comment on attachment 259062 [details] [diff] [review]
use standard readonly alert

over to clint for review

Comment 3

[cmtalbert]

Comment on attachment 259062 [details] [diff] [review]
use standard readonly alert

>Index: calendar/base/public/calIErrors.idl
>===================================================================
>RCS file: /cvsroot/mozilla/calendar/base/public/calIErrors.idl,v
>retrieving revision 1.7
>diff -p -u -r1.7 calIErrors.idl
>--- calendar/base/public/calIErrors.idl	11 Mar 2007 17:03:36 -0000	1.7
>+++ calendar/base/public/calIErrors.idl	20 Mar 2007 02:16:55 -0000
>@@ -105,5 +105,14 @@ interface calIErrors : nsISupports
>    * Range claimed is [ERROR_BASE + 0x200, ERROR_BASE + 0x300)
>    */
>   const unsigned long WCAP_ERROR_BASE = ERROR_BASE + 0x200;
>+  
>+  /**
>+   * (Cal)DAV specific errors
>+   * Range is [ERROR_BASE + 0x301, ERROR_BASE + 0x399]
>+   */
Nit: Please remove the spaces in the blank line above comment block

Index: calendar/locales/en-US/chrome/calendar/calendar.properties
>===================================================================
>RCS file: /cvsroot/mozilla/calendar/locales/en-US/chrome/calendar/calendar.properties,v
>retrieving revision 1.78
>diff -p -u -r1.78 calendar.properties
>--- calendar/locales/en-US/chrome/calendar/calendar.properties	11 Mar 2007 17:03:36 -0000	1.78
>+++ calendar/locales/en-US/chrome/calendar/calendar.properties	20 Mar 2007 02:16:55 -0000
>@@ -185,6 +185,9 @@ minorError=There has been an error readi
> stillReadOnlyError=There has been an error reading data for calendar: %1$S.
> utf8DecodeError=An error occured while decoding an iCalendar (ics) file as UTF-8. Check that the file, including symbols and accented letters, is encoded using the UTF-8 character encoding.
> icsMalformedError=Parsing an iCalendar (ics) file failed. Check that the file conforms to iCalendar (ics) file syntax.
>+dav_notDav=The resource at %1$S is either not a DAV collection or not available
>+dav_davNotCaldav=The resource at %1$S is a DAV collection but not a CalDAV calendar
>+dav_noProps=Unable to get properties of resource %1$S (not a network resource?)

You'll want to update your patch before attempting checkin because the .properties strings did not apply cleanly.

Otherwise, looks good.  I tried it out as well. 
r=ctalbert

Comment 4

[Sebastian Schwieger]

Martin, it looks like this patch needs an update before checkin (see comment 3). Removing the checkin-needed keyword again.

Comment 5

[Bruno Browning]

Attachment: de-nit, de-bitrot patch

this should apply cleanly against the current tree, and the extraneous spaces are now gone.

Comment 6

[Daniel Boelzle [:dbo]]

Comment on attachment 273137 [details] [diff] [review]
de-nit, de-bitrot patch

carrying r+

Comment 7

[Daniel Boelzle [:dbo]]

Checked in on HEAD and MOZILLA_1_8_BRANCH.