Closed
Bug 374567
Opened 19 years ago
Closed 19 years ago
Make GetAppUnitsPerDevUnit return a PRUint32
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
People
(Reporter: roc, Assigned: roc)
Details
Attachments
(1 file)
|
13.53 KB,
patch
|
pavlov
:
review+
|
Details | Diff | Splinter Review |
... as requested.
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #259063 -
Flags: review?(pavlov)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 259063 [details] [diff] [review]
fix
>- double appUnitsPerDevUnit = aTextRun->GetAppUnitsPerDevUnit();
>- double devUnitsPerAppUnit = 1/appUnitsPerDevUnit;
>+ const PRUint32 appUnitsPerDevUnit = aTextRun->GetAppUnitsPerDevUnit();
>+ const double devUnitsPerAppUnit = 1/gfxFloat(appUnitsPerDevUnit);
it seems like it would be more clear here to do 1.0/appUnitsPerDevUnit or 1.0/double(appUnitsPerDevUnit) rather than converting appUnitsPerDevUnit to a gfxFloat and having 1 as an int.. either way.
Attachment #259063 -
Flags: review?(pavlov) → review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
checked in with 1.0/double(appUnitsPerDevUnit).
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•19 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•