374567 - Make GetAppUnitsPerDevUnit return a PRUint32

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

... as requested.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 2

[Stuart Parmenter]

Comment on attachment 259063 [details] [diff] [review]
fix

>-    double appUnitsPerDevUnit = aTextRun->GetAppUnitsPerDevUnit();
>-    double devUnitsPerAppUnit = 1/appUnitsPerDevUnit;
>+    const PRUint32 appUnitsPerDevUnit = aTextRun->GetAppUnitsPerDevUnit();
>+    const double devUnitsPerAppUnit = 1/gfxFloat(appUnitsPerDevUnit);


it seems like it would be more clear here to do 1.0/appUnitsPerDevUnit or 1.0/double(appUnitsPerDevUnit) rather than converting appUnitsPerDevUnit to a gfxFloat and having 1 as an int..  either way.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in with 1.0/double(appUnitsPerDevUnit).